Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to fly@0.7.0 new API #9

Merged
merged 3 commits into from
Aug 21, 2015
Merged

update to fly@0.7.0 new API #9

merged 3 commits into from
Aug 21, 2015

Conversation

ghost
Copy link

@ghost ghost commented Aug 19, 2015

we still need to add tests. I will try to get this done later this week too.

this.filter("less", (source, options) => {
options = assign({}, {
compress: false,
paths: []
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @import is still not working, we can add this bit again.

@watilde
Copy link
Owner

watilde commented Aug 21, 2015

@bucaran Can I take over this PR?

@ghost
Copy link
Author

ghost commented Aug 21, 2015

@watilde Of course and thanks.

@watilde
Copy link
Owner

watilde commented Aug 21, 2015

I updated some code for fixing test case and rebased.

@watilde
Copy link
Owner

watilde commented Aug 21, 2015

Seems ok! After merge this PR, I'll publish as minor updating.

watilde added a commit that referenced this pull request Aug 21, 2015
update to fly@0.7.0 new API
@watilde watilde merged commit 758e8e4 into master Aug 21, 2015
@watilde watilde deleted the fly0.7.0 branch August 21, 2015 12:14
@watilde
Copy link
Owner

watilde commented Aug 21, 2015

@ghost
Copy link
Author

ghost commented Aug 21, 2015

Cool. Don't you think it would be better to test the plugins without Fly? That's what I do here and it works OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant