Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sinks/dashboard] HOTFIX - IMPORTANT: Set Plot Title to 100 char max instead of 50 + Break into 2 lines #367

Merged
merged 6 commits into from
Mar 7, 2025

Conversation

ChrisYx511
Copy link
Contributor

@ChrisYx511 ChrisYx511 commented Mar 7, 2025

Description

Currently, plot title is limited to 50 characters and the current values are all on one line. Reverts change from @BluCodeGH. :(

  • Set limit to 100 chars
  • Added HTML formatting to break current value and series names into 2 lines

This PR closes #366 .

Developer Testing

Here's what I did to test my changes:

  • Ran dashboard, title displays properly

Reviewer Testing

Here's what you should do to quickly validate my changes:

  • Ran dashboard, ensure long plot title displays properly

This change is Reviewable

@ChrisYx511 ChrisYx511 requested review from a team as code owners March 7, 2025 06:16
Copy link
Member

@zangjiucheng zangjiucheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! Few comments address in the code.

@ChrisYx511 ChrisYx511 requested a review from zangjiucheng March 7, 2025 16:23
Copy link
Member

@zangjiucheng zangjiucheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Nice work!

@ChrisYx511
Copy link
Contributor Author

LGTM, Nice work!

Thank you!

@ChrisYx511 ChrisYx511 merged commit c29db62 into master Mar 7, 2025
1 check passed
@ChrisYx511 ChrisYx511 deleted the c424yang/hotfix-fix-dashboard-plot-title branch March 7, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Plot Title not filling available space
2 participants