Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAN 2.0B support #357

Merged
merged 6 commits into from
Feb 26, 2025
Merged

CAN 2.0B support #357

merged 6 commits into from
Feb 26, 2025

Conversation

JasonBrave
Copy link
Member

@JasonBrave JasonBrave commented Feb 9, 2025

Description

I changed X and Y to accomplish Z.

This PR closes #XXX.

Developer Testing

Here's what I did to test my changes:

  • Ran A
  • Ran B
  • Ran C

Reviewer Testing

Here's what you should do to quickly validate my changes:

  • Run D and check output

This change is Reviewable

@JasonBrave JasonBrave marked this pull request as ready for review February 22, 2025 03:16
@JasonBrave JasonBrave requested review from a team as code owners February 22, 2025 03:16
@ChrisYx511
Copy link
Contributor

ChrisYx511 commented Feb 25, 2025

Can we merge waterloo-rocketry/parsley#22 this and then have it point to this one? It's the pyproject.toml change.

Copy link
Member

@zangjiucheng zangjiucheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JasonBrave JasonBrave merged commit 58a35ba into master Feb 26, 2025
2 checks passed
@JasonBrave JasonBrave deleted the j9xu/can-20b-support branch February 26, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants