-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer charging fuel for bulk table
and bulk memory
operations
#676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still perform a check whether the remaining fuel is sufficient before the bulk table or memory operation. For technical reasons we have not yet adjusted the memory.grow operation.
Both now use the new consume_fuel_on_success and share more code in common.
BENCHMARKS
|
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
==========================================
+ Coverage 81.37% 81.41% +0.04%
==========================================
Files 100 100
Lines 8386 8417 +31
==========================================
+ Hits 6824 6853 +29
- Misses 1562 1564 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuel checks are still happening before the bulk operation execution but fuel charging only happens if those operations succeeded.
This make sense given that all of these bulk operations fail fast. So only if they succeeded they actually performed a lot of potential computation.
This affects the following Wasm bulk operations:
memory.grow
: Already implemented deferred fuel charging but this implementation improves upon it.memory.fill
memory.copy
data.init
table.grow
table.fill
table.copy
elem.init