Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure wasmi module structure #648

Merged
merged 17 commits into from
Feb 3, 2023
Merged

Restructure wasmi module structure #648

merged 17 commits into from
Feb 3, 2023

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Feb 3, 2023

No description provided.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.53ms 1.42ms 🟢 -6.77% 1.16ms 1.20ms 🔴 3.02% 🟢 -16%
execute/
bare_call_0/typed
1.05ms 1.03ms 🟢 -2.18% 798.42µs 781.82µs 🟢 -2.05% 🟢 -24%
execute/
bare_call_1
1.57ms 1.45ms 🔴 -7.21% 1.45ms 1.45ms 🟢 -0.32% 🟢 -0%
execute/
bare_call_16
2.41ms 2.45ms 🔴 0.79% 4.37ms 4.40ms ⚪ 0.60% 🟡 79%
execute/
bare_call_16/typed
1.74ms 1.81ms 🔴 3.61% 2.76ms 2.74ms ⚪ -0.52% 🟡 52%
execute/
bare_call_1/typed
1.23ms 1.16ms 🟢 -5.50% 1.26ms 1.16ms 🟢 -8.31% 🟢 -0%
execute/
bare_call_4
1.63ms 1.59ms 🟢 -2.44% 2.11ms 2.12ms ⚪ 0.57% 🟢 33%
execute/
bare_call_4/typed
1.23ms 1.16ms 🟢 -6.18% 1.36ms 1.35ms ⚪ -0.89% 🟢 17%
execute/
br_table
1.18ms 1.15ms 🟢 -2.44% 1.52ms 1.39ms 🟢 -8.08% 🟢 21%
execute/
count_until
651.77µs 652.10µs ⚪ 0.07% 2.29ms 2.29ms ⚪ -0.09% 🔴 251%
execute/
factorial_iterative
327.89µs 325.51µs ⚪ -0.60% 952.10µs 956.78µs ⚪ 0.62% 🔴 194%
execute/
factorial_recursive
659.84µs 691.70µs 🔴 4.87% 1.45ms 1.40ms 🟢 -3.17% 🔴 102%
execute/
fib_iterative
1.48ms 1.36ms 🟢 -8.48% 4.99ms 4.99ms ⚪ 0.06% 🔴 268%
execute/
fib_recursive
6.03ms 6.00ms ⚪ -0.38% 12.50ms 12.62ms ⚪ 1.03% 🔴 110%
execute/
global_bump
976.98µs 978.29µs ⚪ 0.03% 2.69ms 2.62ms 🟢 -2.32% 🔴 168%
execute/
global_const
730.62µs 743.53µs ⚪ 1.75% 2.42ms 2.46ms ⚪ 1.18% 🔴 231%
execute/
host_calls
28.53µs 26.54µs ⚪ -4.31% 40.52µs 40.44µs ⚪ -0.11% 🟡 52%
execute/
memory_fill
1.31ms 1.21ms 🟢 -7.06% 4.17ms 4.17ms ⚪ 0.26% 🔴 244%
execute/
memory_sum
1.30ms 1.18ms 🟢 -9.09% 4.16ms 4.15ms ⚪ -0.04% 🔴 250%
execute/
memory_vec_add
2.47ms 2.47ms ⚪ 0.15% 7.81ms 7.83ms ⚪ 0.43% 🔴 217%
execute/
recursive_is_even
1.24ms 1.14ms ⚪ -4.10% 2.36ms 2.35ms ⚪ -0.49% 🔴 106%
execute/
recursive_ok
157.41µs 161.89µs 🔴 2.79% 324.91µs 328.36µs ⚪ 1.22% 🔴 103%
execute/
recursive_scan
183.24µs 185.00µs ⚪ 3.13% 406.77µs 405.74µs ⚪ -0.12% 🔴 119%
execute/
recursive_trap
15.90µs 15.99µs ⚪ 0.46% 31.99µs 33.45µs 🔴 4.58% 🔴 109%
execute/
regex_redux
524.73µs 529.12µs ⚪ 0.90% 1.42ms 1.42ms ⚪ 0.20% 🔴 168%
execute/
rev_complement
497.16µs 483.62µs 🟢 -2.66% 1.44ms 1.43ms ⚪ -0.63% 🔴 197%
execute/
tiny_keccak
372.46µs 330.53µs 🟢 -11.35% 1.15ms 1.15ms ⚪ 0.06% 🔴 247%
execute/
trunc_f2i
708.33µs 709.85µs ⚪ 0.51% 2.19ms 2.19ms ⚪ 0.05% 🔴 208%
instantiate/
wasm_kernel
65.71µs 67.37µs 🔴 3.49% 68.15µs 69.84µs 🔴 3.86% 🟢 4%
translate/
erc1155
208.17µs 208.52µs ⚪ 0.06% 392.35µs 392.41µs ⚪ -0.15% 🟡 88%
translate/
erc20
103.03µs 103.45µs ⚪ 0.90% 192.38µs 192.20µs ⚪ -0.16% 🟡 86%
translate/
erc721
148.52µs 147.56µs ⚪ -0.24% 280.77µs 278.43µs ⚪ -1.35% 🟡 89%
translate/
spidermonkey
0.00ns 0.00ns ⚪ -0.11% 0.00ns 0.00ns ⚪ 0.91% 🟢 0%
translate/
wasm_kernel
3.75ms 3.77ms ⚪ 0.42% 7.23ms 7.21ms ⚪ -0.32% 🟡 91%

Link to pipeline

@Robbepop Robbepop merged commit 323c0cf into master Feb 3, 2023
@Robbepop Robbepop deleted the rf-further-cleanup branch February 3, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants