-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Wasmtime-like API for wasmi
#615
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More closely mirrors the Wasmtime API.
ExportType is the same name as used in the Wasmtime API.
They now align more closely to Wasmtime docs.
This more closely mirrors what the Wasmtime iterator yields. Before that ExportsIter yielded pairs of (str, Extern) whereas now this pair is wrapped by the new Export type.
BENCHMARKS
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirror Wasmtime API more closely:
Caller::host_data
method toCaller::data
.Caller::host_data_mut
method toCaller::data_mut
.Extern::ty
method and theExternType
type.ExportItem
toExportType
:ExportItem::kind
method toty
and returnExternType
instead ofExportItemKind
.ExportItemKind
entirely.ExportsIter
now yields items of the new typeExport
instead of pairs of(&str, Extern)
.ModuleImport
toImportType
.ImportType::item_type
toty
.ImportType::field
toname
.&str
lifetimes inImportType::{module, name}
.ModuleImportType
byExternType
.Instance
:Instance::get_func
Instance::get_typed_func
Instance::get_global
Instance::get_table
Instance::get_memory