-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use wiggle 2.0. #568
Merged
Merged
Use wiggle 2.0. #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiggle 2.0 still allows removing wasmtime dependencies.
BENCHMARKS
|
Ah nice, you are right! Thanks a lot for the fix. :) |
Robbepop
approved these changes
Nov 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
=======================================
Coverage 80.04% 80.04%
=======================================
Files 78 78
Lines 6323 6323
=======================================
Hits 5061 5061
Misses 1262 1262 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Berrysoft
added a commit
to Berrysoft/Ayaka
that referenced
this pull request
Nov 20, 2022
Related PR: wasmi-labs/wasmi#568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wiggle 2.0 still allows removing wasmtime dependencies.
The one in the main branch of wasmtime repo doesn't allow removing it, but it is v4.0. I'll open an issue about that.
Bonus: fixes #564