Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wiggle 2.0. #568

Merged
merged 1 commit into from
Nov 19, 2022
Merged

Use wiggle 2.0. #568

merged 1 commit into from
Nov 19, 2022

Conversation

Berrysoft
Copy link
Contributor

Wiggle 2.0 still allows removing wasmtime dependencies.

The one in the main branch of wasmtime repo doesn't allow removing it, but it is v4.0. I'll open an issue about that.

Bonus: fixes #564

Wiggle 2.0 still allows removing wasmtime dependencies.
@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.01ms 1.03ms ⚪ 2.49% 921.06µs 884.44µs 🟢 -3.77% 🟢 -14%
execute/
bare_call_0/typed
526.24µs 526.24µs ⚪ 0.09% 414.30µs 401.81µs 🟢 -2.97% 🟢 -24%
execute/
bare_call_1
1.05ms 1.06ms ⚪ 1.78% 1.08ms 1.08ms 🟢 -0.38% 🟢 2%
execute/
bare_call_16
2.20ms 2.19ms ⚪ 0.31% 4.75ms 4.79ms 🟢 0.68% 🔴 119%
execute/
bare_call_16/typed
1.55ms 1.55ms ⚪ -0.26% 2.16ms 2.02ms 🟢 -6.62% 🟢 30%
execute/
bare_call_1/typed
609.84µs 610.14µs ⚪ 0.14% 717.97µs 702.03µs 🟢 -2.46% 🟢 15%
execute/
bare_call_4
1.19ms 1.19ms ⚪ 0.25% 1.75ms 1.73ms ⚪ -0.83% 🟢 46%
execute/
bare_call_4/typed
630.25µs 633.58µs ⚪ 0.62% 807.41µs 800.97µs ⚪ -0.66% 🟢 26%
execute/
br_table
666.60µs 631.60µs ⚪ -3.41% 909.47µs 888.67µs 🟢 -2.19% 🟢 41%
execute/
count_until
650.85µs 650.84µs ⚪ 0.00% 2.06ms 2.07ms ⚪ 0.51% 🔴 218%
execute/
factorial_iterative
310.47µs 309.40µs ⚪ -0.75% 846.21µs 846.27µs ⚪ 0.04% 🔴 174%
execute/
factorial_recursive
616.27µs 614.25µs ⚪ -0.40% 1.29ms 1.25ms 🟢 -2.66% 🔴 104%
execute/
fib_iterative
1.63ms 1.55ms 🟢 -5.47% 4.48ms 4.47ms ⚪ -0.25% 🔴 189%
execute/
fib_recursive
5.75ms 5.75ms ⚪ -0.06% 11.39ms 11.50ms ⚪ 0.89% 🟡 100%
execute/
global_bump
956.56µs 955.01µs ⚪ -0.15% 3.17ms 3.16ms ⚪ -0.24% 🔴 231%
execute/
global_const
800.52µs 818.02µs ⚪ 2.81% 2.33ms 2.31ms ⚪ -0.93% 🔴 183%
execute/
host_calls
29.21µs 29.63µs ⚪ 1.29% 39.86µs 37.93µs 🟢 -4.85% 🟢 28%
execute/
memory_fill
1.31ms 1.31ms ⚪ 0.03% 4.00ms 3.99ms ⚪ -0.32% 🔴 206%
execute/
memory_sum
1.33ms 1.33ms ⚪ 0.19% 3.95ms 3.95ms ⚪ -0.32% 🔴 197%
execute/
memory_vec_add
2.82ms 2.74ms 🟢 -2.99% 8.20ms 8.20ms ⚪ 0.19% 🔴 200%
execute/
recursive_is_even
1.10ms 1.11ms ⚪ 0.11% 2.10ms 2.17ms ⚪ 2.33% 🟡 96%
execute/
recursive_ok
142.10µs 143.36µs ⚪ 0.94% 295.11µs 292.84µs ⚪ -0.78% 🔴 104%
execute/
recursive_scan
178.29µs 181.27µs 🔴 1.49% 377.08µs 374.30µs ⚪ -0.69% 🔴 106%
execute/
recursive_trap
14.17µs 14.42µs ⚪ 1.73% 28.37µs 28.27µs ⚪ -0.07% 🟡 96%
execute/
regex_redux
546.70µs 544.47µs ⚪ -0.34% 1.46ms 1.45ms ⚪ 0.01% 🔴 167%
execute/
rev_complement
522.12µs 525.02µs ⚪ 0.64% 1.44ms 1.43ms ⚪ -0.27% 🔴 173%
execute/
tiny_keccak
370.59µs 370.77µs ⚪ 0.00% 1.23ms 1.22ms ⚪ -0.78% 🔴 229%
execute/
trunc_f2i
922.60µs 915.71µs ⚪ -0.71% 2.43ms 2.44ms ⚪ 0.04% 🔴 166%
instantiate/
wasm_kernel
59.39µs 61.56µs 🔴 4.40% 94.06µs 67.43µs 🟢 -28.02% 🟢 10%
translate/
erc1155
204.89µs 207.39µs ⚪ 0.83% 382.02µs 374.56µs 🟢 -2.07% 🟡 81%
translate/
erc20
100.65µs 100.91µs ⚪ 0.24% 185.62µs 183.90µs ⚪ -1.08% 🟡 82%
translate/
erc721
144.41µs 145.35µs ⚪ 0.64% 271.33µs 266.08µs 🟢 -1.82% 🟡 83%
translate/
spidermonkey
0.00ns 0.00ns ⚪ 0.17% 0.00ns 0.00ns ⚪ -0.48% 🟢 0%
translate/
wasm_kernel
3.76ms 3.75ms ⚪ -0.72% 7.09ms 7.04ms ⚪ -0.67% 🟡 88%

Link to pipeline

@Robbepop
Copy link
Member

Ah nice, you are right! Thanks a lot for the fix. :)

Copy link
Member

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #568 (2dd2e3a) into master (44419e0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #568   +/-   ##
=======================================
  Coverage   80.04%   80.04%           
=======================================
  Files          78       78           
  Lines        6323     6323           
=======================================
  Hits         5061     5061           
  Misses       1262     1262           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Robbepop Robbepop merged commit eaf5e9d into wasmi-labs:master Nov 19, 2022
Berrysoft added a commit to Berrysoft/Ayaka that referenced this pull request Nov 20, 2022
@Berrysoft Berrysoft deleted the patch/wasi branch November 20, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasmi_wasi cannot be built on Windows on Rust nightly
4 participants