Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-trapping-float-to-int-conversions Wasm proposal #359

Merged
merged 4 commits into from
Feb 15, 2022

Conversation

Robbepop
Copy link
Member

Closes #355.

@codecov-commenter
Copy link

Codecov Report

Merging #359 (09752c3) into master (8830ee3) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
+ Coverage   78.70%   78.88%   +0.18%     
==========================================
  Files          96       96              
  Lines       10852    10907      +55     
==========================================
+ Hits         8541     8604      +63     
+ Misses       2311     2303       -8     
Impacted Files Coverage Δ
tests/spec/v1/mod.rs 100.00% <ø> (ø)
wasmi_v1/src/engine/bytecode/mod.rs 100.00% <ø> (ø)
wasmi_v1/src/module/compile/operator.rs 98.07% <ø> (ø)
core/src/value.rs 67.14% <100.00%> (+1.23%) ⬆️
wasmi_v1/src/engine/code_map.rs 88.18% <100.00%> (+0.41%) ⬆️
wasmi_v1/src/engine/exec_context.rs 96.74% <100.00%> (+0.11%) ⬆️
wasmi_v1/src/engine/func_builder/mod.rs 92.21% <100.00%> (+0.16%) ⬆️
wasmi_v1/src/module/compile/mod.rs 38.07% <100.00%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8830ee3...09752c3. Read the comment docs.

@Robbepop Robbepop changed the title Implement Wasm proposal: non-trapping-float-to-int-conversions Support non-trapping-float-to-int-conversions Wasm proposal Feb 13, 2022
@Robbepop
Copy link
Member Author

We might want to wait for bytecodealliance/wasm-tools#481 to merge this so that we can safely guard against unsupported or forbidden Wasm proposal feature usage.

…urating-trunc

# Conflicts:
#	tests/spec/v1/mod.rs
…urating-trunc

# Conflicts:
#	tests/spec/v1/mod.rs
#	wasmi_v1/src/engine/bytecode/mod.rs
#	wasmi_v1/src/engine/bytecode/visitor.rs
#	wasmi_v1/src/engine/code_map.rs
#	wasmi_v1/src/engine/exec_context.rs
#	wasmi_v1/src/engine/func_builder/mod.rs
#	wasmi_v1/src/module/compile/mod.rs
#	wasmi_v1/src/module/compile/operator.rs
@Robbepop Robbepop merged commit 0bfc543 into master Feb 15, 2022
@athei athei deleted the rf-impl-saturating-trunc branch July 26, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Wasm proposal: non-trapping-float-to-int-conversions
2 participants