Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward parity-wasm's feature 'reduced-stack-buffer' #243

Merged
merged 2 commits into from
Sep 20, 2021
Merged

Forward parity-wasm's feature 'reduced-stack-buffer' #243

merged 2 commits into from
Sep 20, 2021

Conversation

ithinuel
Copy link
Contributor

This PR introduces a new feature as a forward of underlying feature introduced in paritytech/parity-wasm#283.

@ithinuel
Copy link
Contributor Author

Update: paritytech/parity-wasm#283 has been merged.

This PR will be rebased with a bump to parity-wasm version once a new one is released.

@ithinuel ithinuel mentioned this pull request Feb 15, 2021
Closed
@jiayihu
Copy link

jiayihu commented Mar 3, 2021 •
edited
Loading

I think parity-wasm should also be updated to 0.42.1 right?

Btw, any estimate on when the PR will be merged?

@pepyakin
Copy link
Collaborator

pepyakin commented Mar 5, 2021

I am actually not sure if it's that version. Not even sure it's released. @athei have you made a release that includes paritytech/parity-wasm#283 ?

@athei
Copy link
Collaborator

athei commented Mar 9, 2021

I am actually not sure if it's that version. Not even sure it's released. @athei have you made a release that includes paritytech/parity-wasm#283 ?

No. Those changes are unreleased. I will do a release.

@athei
Copy link
Collaborator

athei commented Mar 9, 2021 •
edited
Loading

Update: paritytech/parity-wasm#283 has been merged.

This PR will be rebased with a bump to parity-wasm version once a new one is released.

I just released the changes as v0.42.2.

@ithinuel
Copy link
Contributor Author

ithinuel commented Mar 12, 2021 •
edited
Loading

Thank you @athei for the release.

The last step before this PR can be merge-able is to bump wasmi to v0.42.2.
It requires the changes proposed by @jiayihu in f7235e1 as part of the now closed PR #239.

Those changes aren't directly related to the reduced-stack-buffer feature so you may want to see a dedicated PR for the bump before considering this PR.
Let me know what you think is the most appropriate.

@athei
Copy link
Collaborator

athei commented Mar 12, 2021

Please open another PR where you bump parity-wasm.

@ithinuel ithinuel mentioned this pull request Mar 14, 2021
Merged
@ithinuel
Copy link
Contributor Author

PR created here: #251

@ithinuel ithinuel force-pushed the render_constrained_system_friendly branch from f26c9c5 to 55be48f Compare March 18, 2021 10:22
@stevemk14ebr
Copy link

Can this please be merged

@athei athei requested a review from pepyakin September 20, 2021 07:34
@athei athei mentioned this pull request Sep 20, 2021
Closed
@pepyakin pepyakin merged commit 2280325 into wasmi-labs:master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepyakin pepyakin pepyakin approved these changes

@athei athei athei approved these changes

@coriolinus coriolinus coriolinus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ithinuel @jiayihu @pepyakin @athei @stevemk14ebr @coriolinus