Experimental: Improve wasmi_ir
generated constructors
#1188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is experimental and I am not sure if merging this will improve
wasmi_ir::Instruction
constructors substantially enough to compensate for the disadvantages of the chosen approach.This primarily changes some constructor parameters, e.g.:
values: impl Into<[Reg; 2]>
becomesvalues: [impl Into<Reg>; 2]
len_targets: impl Into<u32>
becomeslen_targets: u32
This PR does not touch constructors for
InstrSequence
.The major disadvantage (besides the complexity) is that we have to wrap some of the field types with
()
, e.g.Const16<i32>
becomes(Const16<i32>)
. This does not change semantics of the type since both are equal but it allows to match all field types astt
(token-tree) inmacro_rules
macros.A proc. macro based approach could yield better results without the aforementioned disadvantage.