Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use named fields for some Instruction variants #1162

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Sep 4, 2024

Simplifies #1152 integration later on.

@Robbepop Robbepop mentioned this pull request Sep 4, 2024
8 tasks
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 43.17549% with 204 lines in your changes missing coverage. Please review.

Project coverage is 79.17%. Comparing base (3f9bb82) to head (e6f6eee).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/wasmi/src/engine/executor/instrs.rs 38.46% 80 Missing ⚠️
...ates/wasmi/src/engine/translator/visit_register.rs 3.03% 64 Missing ⚠️
crates/wasmi/src/engine/executor/instrs/branch.rs 4.76% 40 Missing ⚠️
...rates/wasmi/src/engine/translator/instr_encoder.rs 72.46% 19 Missing ⚠️
...rates/wasmi/src/engine/translator/relink_result.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1162      +/-   ##
==========================================
- Coverage   79.29%   79.17%   -0.12%     
==========================================
  Files         296      296              
  Lines       25357    25400      +43     
==========================================
+ Hits        20106    20111       +5     
- Misses       5251     5289      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit bb031ed into main Sep 4, 2024
16 of 18 checks passed
@Robbepop Robbepop deleted the rf-adjust-instruction-enum branch September 4, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant