Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement re-designed Wasmi select instructions #1157

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

Robbepop
Copy link
Member

This simplifies integration of #1152.

@Robbepop Robbepop mentioned this pull request Aug 31, 2024
8 tasks
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 73.66548% with 74 lines in your changes missing coverage. Please review.

Project coverage is 79.62%. Comparing base (23971c1) to head (1885192).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/wasmi/src/engine/executor/instrs/select.rs 33.96% 35 Missing ⚠️
crates/wasmi/src/engine/translator/mod.rs 90.97% 12 Missing ⚠️
crates/wasmi/src/engine/executor/instrs.rs 33.33% 10 Missing ⚠️
...ates/wasmi/src/engine/translator/visit_register.rs 18.18% 9 Missing ⚠️
...rates/wasmi/src/engine/translator/relink_result.rs 20.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1157      +/-   ##
==========================================
- Coverage   79.66%   79.62%   -0.04%     
==========================================
  Files         296      296              
  Lines       25491    25533      +42     
==========================================
+ Hits        20307    20331      +24     
- Misses       5184     5202      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit af476f9 into main Aug 31, 2024
16 of 18 checks passed
@Robbepop Robbepop deleted the rf-impl-new-select-instrs branch August 31, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant