fix bugs in emscripten socket syscalls #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 6, 2019
484: fix bugs in emscripten socket syscalls r=MarkMcCaskey a=MarkMcCaskey resolves #482 This PR fixes: - incorrect argument order - which cascaded in to a casting issue - which cascaded in to misaligning the arguments of a function - which cascaded in to attempting to access an OOB pointer - sets fd limit to 1024, rather than emscripten's 64 - updates `prlimit64` to return the correct result for `RLIMIT_NOFILE` - fixes bug in `prlimit64` due to a mistransaltion of the emscripten javascript Co-authored-by: Mark McCaskey <mark@wasmer.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #482
This PR fixes:
prlimit64to return the correct result forRLIMIT_NOFILEprlimit64due to a mistransaltion of the emscripten javascript