Remove "build_linux_riscv64" as a pre-requisite for running CLI integration tests #4005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptitSeb
approved these changes
Jun 16, 2023
|
This PR is no longer needed because riscv was fixed in #4002. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've started getting build issues in CI with the
build_riscv64jobs because of changes in the Debian repositories. This PR removesbuild_linux_riscv64(both the C API and Wasmer CLI) as a pre-requisite for running the CLI integration tests.We don't test the CLI for riscv at the moment, so this shouldn't be a problem.
This PR doesn't ignore the riscv builds completely, so
masterwill still be red. It just means we can unblock PRs currently waiting for CI to pass.When #4002 is merged again, we should either revert this PR or update branch protections to make the job required.