Use standard API for js and sys for Module. Added Engine in js #3556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: wasmer_vm::TrapHandler was never exposed via the `wasmer` crate, so it’s safe to remove
theduke
previously approved these changes
Feb 28, 2023
# Conflicts: # lib/api/src/js/externals/global.rs # lib/api/src/js/vm.rs # lib/wasi/src/bin_factory/exec.rs # lib/wasi/src/bin_factory/module_cache.rs # lib/wasi/src/runtime/task_manager/mod.rs
# Conflicts: # lib/api/src/js/externals/global.rs # lib/api/src/js/vm.rs # lib/cli/src/commands/create_exe.rs # lib/wasi/src/bin_factory/exec.rs # lib/wasi/src/bin_factory/module_cache.rs # lib/wasi/src/os/console/mod.rs # lib/wasi/src/runtime/task_manager/mod.rs
# Conflicts: # lib/api/src/js/mem_access.rs # lib/api/src/lib.rs # lib/api/src/mem_access.rs # lib/api/src/ptr.rs
This was referenced Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to standardize the API for js/sys using a similar strategy as Rust is doing when offering the same API in different Operating Systems.
This PR aims to move things one at a time, so it's easier to test along the process.
APIs generalized:
StoreEngineModuleInstanceImportsExportsFunctionNativeFunctionGlobalMemoryMemoryViewTableNativeTypeFunctionEnvWasmPtrWasmRef,WasmSlice,WasmSliceIter(frommem_access.rs)TrapValuePerhaps, also optional but maybe interesting
ExternRef- Implement ExternRef in wasmer-js #3224