Update wasmer-toml version #3494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theduke
reviewed
Jan 19, 2023
|
See #3492 for related discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs: one is that we cannot run packages with a
CommandV1command, since themodulename was never found, the other bug is that the[fs]section is currently non-deterministic with regards to how filesystem mappings overlap each other (mapping/,/lib,/lib/a/b/cleads to a situation where the/lib/a/b/cwould shadow the/mapping).I've tracked the FS issues in #3492 since they appeared in the hackathon. For now it's okay to use
IndexMapto work around this issue, but we need to track it and fix it properly in the future.