Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This should fix CI build of CAPI Headless #3479

Merged
merged 3 commits into from
Jan 16, 2023
Merged

This should fix CI build of CAPI Headless #3479

merged 3 commits into from
Jan 16, 2023

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Jan 16, 2023

Description

Command lines arguments are not correctly built when the Makefile is used from the CI and build CAPI Headless.

Michael-F-Bryan
Michael-F-Bryan approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to run this locally because I don't have access to the wasmer/aarch64 Docker image, but looking at the commands Make would be running, this should fix the issue on master 👍

@ptitSeb ptitSeb merged commit 833ca02 into master Jan 16, 2023
@ptitSeb ptitSeb deleted the fix_makefile-capi-headless branch January 16, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-F-Bryan Michael-F-Bryan Michael-F-Bryan approved these changes

@fschutt fschutt Awaiting requested review from fschutt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptitSeb @Michael-F-Bryan