Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add preopened fd and fix/improve fs syscalls; fix wasi memory access #343

Merged
merged 11 commits into from
Apr 19, 2019
Merged

add preopened fd and fix/improve fs syscalls; fix wasi memory access #343

merged 11 commits into from
Apr 19, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey commented Apr 11, 2019 •
edited
Loading

resolves #356

@MarkMcCaskey MarkMcCaskey added the 📦 lib-wasi About wasmer-wasi label Apr 11, 2019
@xmclark xmclark self-requested a review April 12, 2019 14:36
@MarkMcCaskey MarkMcCaskey mentioned this pull request Apr 15, 2019
Closed
Kerollmops
Kerollmops reviewed Apr 15, 2019
View reviewed changes
src/bin/wasmer.rs Outdated Show resolved Hide resolved
@MarkMcCaskey MarkMcCaskey marked this pull request as ready for review April 19, 2019 00:49
@MarkMcCaskey MarkMcCaskey changed the title add preopened fd and fix/improve fs syscalls (WIP) add preopened fd and fix/improve fs syscalls Apr 19, 2019
@MarkMcCaskey MarkMcCaskey changed the title add preopened fd and fix/improve fs syscalls add preopened fd and fix/improve fs syscalls; fix wasi memory access Apr 19, 2019
MarkMcCaskey
MarkMcCaskey commented Apr 19, 2019
View reviewed changes
lib/wasi/src/state.rs Outdated Show resolved Hide resolved
lachlansneff
lachlansneff reviewed Apr 19, 2019
View reviewed changes
lib/wasi/src/syscalls/mod.rs Outdated Show resolved Hide resolved
lib/wasi/src/syscalls/mod.rs Outdated Show resolved Hide resolved
lib/wasi/src/ptr.rs Show resolved Hide resolved
lachlansneff
lachlansneff approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@lachlansneff lachlansneff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, looks fine

@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Apr 19, 2019
@bors
Merge #343
88fc562 
343: add preopened fd and fix/improve fs syscalls; fix wasi memory access r=MarkMcCaskey a=MarkMcCaskey

resolves #356 

Co-authored-by: Mark McCaskey <mark@wasmer.io>
@bors
Copy link
Contributor

bors bot commented Apr 19, 2019

Canceled

@syrusakbary
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 19, 2019

Merge conflict

@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Apr 19, 2019
@bors @syrusakbary @MarkMcCaskey
Merge #343
f7e4a09 
343: add preopened fd and fix/improve fs syscalls; fix wasi memory access r=MarkMcCaskey a=MarkMcCaskey

resolves #356 

Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Syrus Akbary <me@syrusakbary.com>
Co-authored-by: Mark McCaskey <markmccaskey@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Apr 19, 2019

Build succeeded

@bors bors bot merged commit 5a575cd into master Apr 19, 2019
@bors bors bot deleted the feature/preopen-fd-and-more branch April 19, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops left review comments

@lachlansneff lachlansneff lachlansneff approved these changes

@xmclark xmclark Awaiting requested review from xmclark

Assignees
No one assigned
Labels
📦 lib-wasi About wasmer-wasi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rust program can not open a file
4 participants
@MarkMcCaskey @syrusakbary @Kerollmops @lachlansneff