Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually catch traps/panics/etc when using a typed func. #338

Merged
merged 9 commits into from
Apr 10, 2019
Merged

Actually catch traps/panics/etc when using a typed func. #338

merged 9 commits into from
Apr 10, 2019

Conversation

lachlansneff
Copy link
Contributor

Some niche code in some of the other libraries will need to be added.

@lachlansneff
Copy link
Contributor Author

Okay, let's give this a try.
bors try

bors bot added a commit that referenced this pull request Apr 9, 2019
@bors
Try #338:
5b15dbc
@bors
Copy link
Contributor

bors bot commented Apr 9, 2019

try

Build failed

@lachlansneff
Copy link
Contributor Author

once more

bors try

bors bot added a commit that referenced this pull request Apr 9, 2019
@bors
Try #338:
1651dea
@bors
Copy link
Contributor

bors bot commented Apr 9, 2019

try

Build failed

@lachlansneff
Copy link
Contributor Author

trying to fix windows build
bors try

bors bot added a commit that referenced this pull request Apr 9, 2019
@bors
Try #338:
3e96f7f
@bors
Copy link
Contributor

bors bot commented Apr 9, 2019

try

Build failed

@lachlansneff
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Apr 9, 2019
@bors
Try #338:
b3cd727
@bors
Copy link
Contributor

bors bot commented Apr 9, 2019

try

Build failed

@lachlansneff
Copy link
Contributor Author

pls
bors try

bors bot added a commit that referenced this pull request Apr 9, 2019
@bors
Try #338:
11dd9b6
@bors
Copy link
Contributor

bors bot commented Apr 10, 2019

try

Build succeeded

@syrusakbary syrusakbary mentioned this pull request Apr 10, 2019
Closed
@bjfish
Copy link
Contributor

bjfish commented Apr 10, 2019

It would be nice if there was more comments/documentation. For example, the get_wasm_trampoline could describe what is trampoline, where are they used, why are they're need. Or each of the traits/structs could describe their purpose.

@lachlansneff
Copy link
Contributor Author

@bjfish Good idea, I'll do that before merging.

@lachlansneff
Copy link
Contributor Author

prays to the git gods
bors r+

bors bot added a commit that referenced this pull request Apr 10, 2019
@bors @lachlansneff
Merge #338
44fdd89 
338: Actually catch traps/panics/etc when using a typed func. r=lachlansneff a=lachlansneff

Some niche code in some of the other libraries will need to be added.

Co-authored-by: Lachlan Sneff <lachlan.sneff@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 10, 2019

Build succeeded

@bors bors bot merged commit 2d2a177 into master Apr 10, 2019
@bors bors bot deleted the feature/func.call-check branch April 10, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjfish bjfish bjfish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lachlansneff @bjfish