Update to Cranelift 0.3.0 #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjfish
commented
Apr 3, 2019
| ) -> cranelift_wasm::SignatureIndex { | ||
| let sig_index: SigIndex = self.module.info.func_assoc[Converter(func_index).into()]; | ||
| Converter(sig_index).into() | ||
| } |
There was a problem hiding this comment.
These were the only two of the removed trait methods that were used within our codebase, so I added them back here.
|
bors try |
syrusakbary
reviewed
Apr 3, 2019
Remove unnecessary `<'a>` from Converter Co-Authored-By: bjfish <bjfish@users.noreply.github.com>
|
bors try |
|
bors try |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 4, 2019
321: Update to Cranelift 0.3.0 r=bjfish a=bjfish Some API changes were addressed: - `ModuleEnvironment` many trait methods removed: bytecodealliance/cranelift@459f6dd#diff-0682a088315ee358a75d4b60bc72dafc - `declare_table_elements` parameter type changed: bytecodealliance/cranelift@64ea964 - `UnreachableCodeReached` trap code added: bytecodealliance/cranelift@1c43ad7 - `declare_signature` signature updated: bytecodealliance/cranelift@8a24539 - `define_function_body` parameter added: bytecodealliance/cranelift@37dffda - `target_lexicon` dependency updated to version `0.3.0` Co-authored-by: Brandon Fish <brandon.j.fish@gmail.com> Co-authored-by: Syrus Akbary <me@syrusakbary.com> Co-authored-by: Brandon Fish <bjfish@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some API changes were addressed:
ModuleEnvironmentmany trait methods removed: bytecodealliance/cranelift@459f6dd#diff-0682a088315ee358a75d4b60bc72dafcdeclare_table_elementsparameter type changed: bytecodealliance/cranelift@64ea964UnreachableCodeReachedtrap code added: bytecodealliance/cranelift@1c43ad7declare_signaturesignature updated: bytecodealliance/cranelift@8a24539define_function_bodyparameter added: bytecodealliance/cranelift@37dffdatarget_lexicondependency updated to version0.3.0