Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C-API: add functions to overwrite stdin / stdout / stderr handlers #3145

Merged
merged 80 commits into from
Oct 17, 2022
Merged

C-API: add functions to overwrite stdin / stdout / stderr handlers #3145

merged 80 commits into from
Oct 17, 2022

Commits on Aug 5, 2022

  1. c-api: add functions to overwrite stdin and to write to it 

    Fixes #2334
    @epilys @fschutt
    epilys authored and fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    f3fc438 View commit details
    Browse the repository at this point in the history

  2. Refactor overriding stdin / stdout / stderr into wasi_console_io_over… 

    …ride_t
    @fschutt
    fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    b1c77a1 View commit details
    Browse the repository at this point in the history

  3. Add (non-working) unit test

    @fschutt
    fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    759b2f6 View commit details
    Browse the repository at this point in the history

  4. Remove wasi_env_write_stdin

    @fschutt
    fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    8e5ff7d View commit details
    Browse the repository at this point in the history

  5. Fix C API

    @fschutt
    fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    dccaa3f View commit details
    Browse the repository at this point in the history

  6. Make capi unit test functional, finalize C API

    @fschutt
    fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    d0ccb34 View commit details
    Browse the repository at this point in the history

  7. Fix double free() in deallocation of WasiConsoleMemoryOverride

    @fschutt
    fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    660f866 View commit details
    Browse the repository at this point in the history

  8. Rename "wasi_console_io_override_t" to "wasi_console_out_t"

    @fschutt
    fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    127e06d View commit details
    Browse the repository at this point in the history

  9. Added API for wasi_stdin_t

    @fschutt
    fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    5103306 View commit details
    Browse the repository at this point in the history

  10. Finalize API for stdin API rewrite

    @fschutt
    fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    8c36f06 View commit details
    Browse the repository at this point in the history

  11. Try debuggint unit test test_wasi_stdin_set

    @fschutt
    fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    dfe4e8e View commit details
    Browse the repository at this point in the history

  12. Fixed stdin-capi unit test not running due to missing imports

    @fschutt
    fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    f4ff4bc View commit details
    Browse the repository at this point in the history

  13. Fix C-API stdin PR: read correct amount of bytes and fix stdout cursor

    @fschutt
    fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    5e83b80 View commit details
    Browse the repository at this point in the history

  14. cargo fmt

    @fschutt
    fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    ed4fb72 View commit details
    Browse the repository at this point in the history

  15. Fix __u_long to size_t in C API

    @fschutt
    fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    aa27a66 View commit details
    Browse the repository at this point in the history

  16. Change size_t to unsigned long

    @fschutt
    fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    2ff8d34 View commit details
    Browse the repository at this point in the history

  17. Use int64_t / uintptr_t

    @fschutt
    fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    1224700 View commit details
    Browse the repository at this point in the history

  18. cargo update

    @fschutt
    fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    f1a3350 View commit details
    Browse the repository at this point in the history

  19. Fix clippy errors in lib/c-api/src/wasm_c_api/wasi/mod.rs

    @fschutt
    fschutt committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    ac127d8 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Merge branch 'master' into capi-wasi-overwrite-stdin

    @fschutt
    fschutt authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    18709f2 View commit details
    Browse the repository at this point in the history

  2. Use wasi::Pipe

    @fschutt
    fschutt committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    838d932 View commit details
    Browse the repository at this point in the history

  3. First work to translate from WasiConsoleMemoryOverride to Pipe

    @fschutt
    fschutt committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    df05679 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Implement console_io_memory using wasi::Pipe

    @fschutt
    fschutt committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    662be61 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into capi-wasi-overwrite-stdin

    @fschutt
    fschutt authored Aug 18, 2022
    Configuration menu
    Copy the full SHA
    9c4bc82 View commit details
    Browse the repository at this point in the history

  3. Address review changes

    @fschutt
    fschutt committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    16f7ff7 View commit details
    Browse the repository at this point in the history

  4. Fix errors in make test-capi

    @fschutt
    fschutt committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    b7f30c9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into capi-wasi-overwrite-stdin

    @fschutt
    fschutt authored Aug 18, 2022
    Configuration menu
    Copy the full SHA
    a93f589 View commit details
    Browse the repository at this point in the history

  6. cargo fmt && make lint

    @fschutt
    fschutt committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    6e944fa View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. Adress review comment: rename wasi_console_out_new -> wasi_pipe_new

    @fschutt
    fschutt committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    63d709e View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Merge branch 'master' into capi-wasi-overwrite-stdin-3

    @fschutt
    fschutt authored Aug 30, 2022
    Configuration menu
    Copy the full SHA
    61ff302 View commit details
    Browse the repository at this point in the history

  2. Fix make lint

    @fschutt
    fschutt committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    67ed624 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. Merge branch 'master' into capi-wasi-overwrite-stdin-3

    @fschutt
    fschutt authored Sep 2, 2022
    Configuration menu
    Copy the full SHA
    a9f1cc8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into capi-wasi-overwrite-stdin-3

    @fschutt
    fschutt authored Sep 2, 2022
    Configuration menu
    Copy the full SHA
    fb1fadb View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Implement Write + Seek for WasiPipe

    @fschutt
    fschutt committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    b046463 View commit details
    Browse the repository at this point in the history

  2. Added WasiPipePair to make the transition to two pipes easier

    @fschutt
    fschutt committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    fac6d0f View commit details
    Browse the repository at this point in the history

  3. cargo fmt

    @fschutt
    fschutt committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    8bf26a3 View commit details
    Browse the repository at this point in the history

  4. Added intial API for creating two-channel pipes

    @fschutt
    fschutt committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    dcadaf2 View commit details
    Browse the repository at this point in the history

  5. Added WasiPipe test to test reading / writing

    @fschutt
    fschutt committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    2a5d267 View commit details
    Browse the repository at this point in the history

  6. C-API: Implement stdio override with WasiPipe instead of custom impl

    @fschutt
    fschutt committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    d26edf9 View commit details
    Browse the repository at this point in the history

  7. Rename wasi_console_out_t to wasi_pipe_t

    @fschutt
    fschutt committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    815da05 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Fix stdio tests for WasiPipe (currently still failing)

    @fschutt
    fschutt committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    1f4c46b View commit details
    Browse the repository at this point in the history

  2. Fix unit test with proper compiled .wasm file

    @fschutt
    fschutt committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    d840b5c View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Merge branch 'master' into capi-wasi-overwrite-stdin-3

    @fschutt
    fschutt authored Sep 8, 2022
    Configuration menu
    Copy the full SHA
    d8e19ba View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. "Fix" WasiPipe to allow multiple-write-single-read buffers

    @fschutt
    fschutt committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    6f35fb5 View commit details
    Browse the repository at this point in the history

  2. Fix "make lint"

    @fschutt
    fschutt committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    6b6785b View commit details
    Browse the repository at this point in the history

  3. Fix WasiPipe + examples

    @fschutt
    fschutt committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    c4a16ae View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Merge branch 'master' into capi-wasi-overwrite-stdin-3

    @fschutt
    fschutt authored Sep 19, 2022
    Configuration menu
    Copy the full SHA
    2c76d73 View commit details
    Browse the repository at this point in the history

  2. Address review comments to prevent leak with Arc::try_unwrap

    @fschutt
    fschutt committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    2484db9 View commit details
    Browse the repository at this point in the history

  3. Add bytes_available function

    @fschutt
    fschutt committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    aa4b1d0 View commit details
    Browse the repository at this point in the history

  4. Rename inherit_stdout -> stdout

    @fschutt
    fschutt committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    1825e60 View commit details
    Browse the repository at this point in the history

  5. Rename WasiPipePair -> WasiBidirectionalPipePair

    @fschutt
    fschutt committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    0e53d2d View commit details
    Browse the repository at this point in the history

  6. Remove debug eprintln

    @fschutt
    fschutt committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    238aef3 View commit details
    Browse the repository at this point in the history

  7. Reexport WasiBidirectionalSharedPipePair as Pipe

    @fschutt
    fschutt committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    6439997 View commit details
    Browse the repository at this point in the history

  8. Added set_blocking method to control blocking behaviour for WasiPipe

    @fschutt
    fschutt committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    f21689d View commit details
    Browse the repository at this point in the history

  9. cargo fmt

    @fschutt
    fschutt committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    72acbc8 View commit details
    Browse the repository at this point in the history

  10. Allow dead code (?)

    @fschutt
    fschutt committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    497592a View commit details
    Browse the repository at this point in the history

  11. Try fixing failing JS tests

    @fschutt
    fschutt committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    8aa69d2 View commit details
    Browse the repository at this point in the history

  12. Set blocking = false for all tests

    @fschutt
    fschutt committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    0e5b55f View commit details
    Browse the repository at this point in the history

  13. cargo fmt

    @fschutt
    fschutt committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    6a91ed7 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Merge branch 'master' into capi-wasi-overwrite-stdin-3

    @fschutt
    fschutt authored Sep 22, 2022
    Configuration menu
    Copy the full SHA
    f1fe308 View commit details
    Browse the repository at this point in the history

  2. Prevent CI from locking up when running WasiTest

    @fschutt
    fschutt committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    7d44c13 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Merge branch 'master' into capi-wasi-overwrite-stdin-3

    @fschutt
    fschutt authored Sep 27, 2022
    Configuration menu
    Copy the full SHA
    3089d4d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into capi-wasi-overwrite-stdin-3

    @fschutt
    fschutt authored Sep 27, 2022
    Configuration menu
    Copy the full SHA
    a90dea6 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Fix ambigouusly named "config" and "stdin" params

    @fschutt
    fschutt committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    703dbce View commit details
    Browse the repository at this point in the history

  2. cargo fmt

    @fschutt
    fschutt committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    28c0e9c View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Merge branch 'master' into capi-wasi-overwrite-stdin-3

    @fschutt
    fschutt authored Oct 4, 2022
    Configuration menu
    Copy the full SHA
    14d0614 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Merge branch 'master' into capi-wasi-overwrite-stdin-3

    @fschutt
    fschutt authored Oct 11, 2022
    Configuration menu
    Copy the full SHA
    2414636 View commit details
    Browse the repository at this point in the history

  2. Fix merge issues

    @fschutt
    fschutt committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    68bc7cc View commit details
    Browse the repository at this point in the history

  3. cargo fmt

    @fschutt
    fschutt committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    3eb2008 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into capi-wasi-overwrite-stdin-3

    @fschutt
    fschutt authored Oct 11, 2022
    Configuration menu
    Copy the full SHA
    0a50a17 View commit details
    Browse the repository at this point in the history

  5. WIP: prepare buffered reads to Pipe instead of reading data on-demand

    @fschutt
    fschutt committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    b20b88b View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Fix PR review comments from john

    @fschutt
    fschutt committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    6b5c746 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Merge branch 'master' into capi-wasi-overwrite-stdin-3

    @fschutt
    fschutt authored Oct 14, 2022
    Configuration menu
    Copy the full SHA
    e38aca6 View commit details
    Browse the repository at this point in the history

  2. Fix CI issues

    @fschutt
    fschutt committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    2422888 View commit details
    Browse the repository at this point in the history

  3. cargo fmt

    @fschutt
    fschutt committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    ace2d9f View commit details
    Browse the repository at this point in the history

  4. cargo clippy --fix

    @fschutt
    fschutt committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    67d6501 View commit details
    Browse the repository at this point in the history

  5. Try fixing CI issue w. TokenStream

    @fschutt
    fschutt committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    ba5c1b8 View commit details
    Browse the repository at this point in the history

  6. Use into() instead of TokenStream::from

    @fschutt
    fschutt committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    8951c9d View commit details
    Browse the repository at this point in the history

  7. "config" -> "wasi_config"

    @fschutt
    fschutt committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    f6fa5b7 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Fix WASI pipe to properly store read bytes in temp_buffer

    @fschutt
    fschutt committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    05d74ea View commit details
    Browse the repository at this point in the history