feat(vfs) Make host_fs the default, and exclusive to mem_fs
#2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch generates a compiler error if `host_fs` and `mem_fs` are both enabled at compile-time. It also generates a compiler error if none of them have been enabled.
Hywan
requested review from
jubianchi,
MarkMcCaskey and
syrusakbary
as code owners
`wasmer-wasi`'s default features don't change, except that it adds `host_fs` in the default features, which maps to `wasmer-vfs/host_fs`. It then ensures that the same behavior is guaranteed. We don't need to change how `wasmer-cli` and `wasmer-c-api` fetch `wasmer-wasi` in this case.
syrusakbary
reviewed
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch makes
host_fspart of the default features. It also makeshost_fsmutually eclusive tomem_fs. Finally, it generates a final compiler error if none of them have been enabled.Finally (promise), it fixes the
Cargo.tomlfile ofwasmer-cliandwasmer-c-apibecause the changes weren't required. See 5b53c54 for more explanations.Address a feedback in #2491.