Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add notes for llvm #2458

Merged
merged 2 commits into from
Jul 8, 2021
Merged

add notes for llvm #2458

merged 2 commits into from
Jul 8, 2021

Conversation

chenyukang
Copy link
Contributor

@chenyukang chenyukang commented Jul 8, 2021 •
edited
Loading

Description

Add details for LLVM dependency.

close issue #2435

@chenyukang chenyukang requested a review from losfair as a code owner July 8, 2021 13:41
@chenyukang
Copy link
Contributor Author

chenyukang commented Jul 8, 2021 •
edited
Loading

Is there any better way to pass a parameter for "bash -c“ ? @Hywan

@Hywan
Copy link
Contributor

Hywan commented Jul 8, 2021

I don't know :-).

@Hywan Hywan self-assigned this Jul 8, 2021
@Hywan Hywan added 📚 documentation Do you like to read? 📦 lib-compiler-llvm About wasmer-compiler-llvm 🎉 enhancement New feature! labels Jul 8, 2021
@chenyukang
Copy link
Contributor Author

https://apt.llvm.org/llvm.sh will prepare everything ok for LLVM,
I didn't know it, since I only reading the official document website,
so it's better add this PR:
https://github.com/wasmerio/docs.wasmer.io/pull/129/files

syrusakbary
syrusakbary approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@syrusakbary
Copy link
Member

I'll merge manually after #2457 is merged

@syrusakbary syrusakbary merged commit ec36089 into wasmerio:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@losfair losfair Awaiting requested review from losfair

Assignees

@Hywan Hywan

Labels
📚 documentation Do you like to read? 🎉 enhancement New feature! 📦 lib-compiler-llvm About wasmer-compiler-llvm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenyukang @Hywan @syrusakbary