Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement bulk memory instructions #2296

Merged
merged 4 commits into from
May 6, 2021
Merged

Implement bulk memory instructions #2296

merged 4 commits into from
May 6, 2021

Conversation

MarkMcCaskey
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey commented May 6, 2021 •
edited
Loading

resolves #2252

Progress:

  • Cranelift (bulk.wast was failing in CI? need to investigate)
  • LLVM
  • Singlepass

Review

  • Add a short description of the change to the CHANGELOG.md file

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 6, 2021
@bors
Try #2296:
a92a9d4
@bors
Copy link
Contributor

bors bot commented May 6, 2021

try

Build failed:

@MarkMcCaskey
Copy link
Contributor Author

bors try-

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 6, 2021
@bors
Try #2296:
f750ca6
@bors
Copy link
Contributor

bors bot commented May 6, 2021

try

Build failed:

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 6, 2021
@bors
Try #2296:
1be3265
@bors
Copy link
Contributor

bors bot commented May 6, 2021

try

Build succeeded:

@syrusakbary
Copy link
Member

Since all tests passed and the PR is approved I'll merge manually to skip more CI time

@syrusakbary syrusakbary merged commit 77fa434 into master May 6, 2021
@bors bors bot deleted the feature/bulk-memory branch May 6, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@losfair losfair Awaiting requested review from losfair

@nlewycky nlewycky Awaiting requested review from nlewycky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does the LLVM Compiler Support bulk_memory?
2 participants
@MarkMcCaskey @syrusakbary