Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CLI to exec WASI w/ multiple namespaces #2251

Merged
merged 3 commits into from
Apr 28, 2021

Conversation

MarkMcCaskey
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey commented Apr 22, 2021

resolves #2226

Added a warning when it's done and a flag to opt out of the warning: --allow-multiple-wasi-versions

Wasm module to test with: mixed-wasi.wasm.tar.gz

Review

  • Add a short description of the change to the CHANGELOG.md file

Added a warning when it's done and a flag to opt out of the warning: `--allow-multiple-wasi-versions`
@MarkMcCaskey MarkMcCaskey force-pushed the feature/multiple-wasi-versions-in-li branch from b3a17b8 to bc9706e Compare April 22, 2021 15:34
Copy link
Contributor

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good patch. It looks good to me!

lib/cli/src/commands/run/wasi.rs Outdated Show resolved Hide resolved
lib/wasi/src/lib.rs Show resolved Hide resolved
lib/wasi/src/utils.rs Show resolved Hide resolved
lib/wasi/src/utils.rs Show resolved Hide resolved
lib/cli/src/commands/run/wasi.rs Show resolved Hide resolved
@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Apr 27, 2021
@bors
Copy link
Contributor

bors bot commented Apr 27, 2021

try

Build failed:

@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Apr 28, 2021
2251: Allow CLI to exec WASI w/ multiple namespaces r=MarkMcCaskey a=MarkMcCaskey

resolves #2226 

Added a warning when it's done and a flag to opt out of the warning: `--allow-multiple-wasi-versions`

Wasm module to test with: [mixed-wasi.wasm.tar.gz](https://github.com/wasmerio/wasmer/files/6360575/mixed-wasi.wasm.tar.gz)

# Review

- [x] Add a short description of the change to the CHANGELOG.md file


Co-authored-by: Mark McCaskey <mark@wasmer.io>
@bors
Copy link
Contributor

bors bot commented Apr 28, 2021

Timed out.

@MarkMcCaskey MarkMcCaskey merged commit 626fb5c into master Apr 28, 2021
@bors bors bot deleted the feature/multiple-wasi-versions-in-li branch April 28, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to run file with imports from both "wasi_unstable" and "wasi_snapshot_preview1"
2 participants