feat(llvm): Make NaN canonicalization configurable #2161

jubianchi · 2021-03-03T12:31:50Z

compiler-llvm now uses the experimental.constrained intrinsics to ensure
correct behavior on FP operations when full-canonicalization is
disabled.

This patch requires TheDan64/inkwell#247

Review

Add a short description of the the change to the CHANGELOG.md file

jubianchi · 2021-03-03T12:44:03Z

bors try

bors · 2021-03-03T12:53:16Z

try

Build failed:

Test on linux-aarch64

jubianchi · 2021-03-03T13:45:04Z

bors try

bors · 2021-03-03T14:11:08Z

try

Build failed:

Test on linux-x64

lib/c-api/src/wasm_c_api/engine.rs

jubianchi · 2021-03-03T17:32:37Z

bors try

bors · 2021-03-03T18:06:28Z

try

Build succeeded:

lib/c-api/src/wasm_c_api/engine.rs

lib/compiler-singlepass/src/config.rs

lib/compiler/src/compiler.rs

tests/ignores.txt

lib/compiler-llvm/src/translator/code.rs

lib/compiler-llvm/src/config.rs

tests/wast/wasmer/nan-canonicalization.wast

jubianchi · 2021-04-30T22:01:01Z

bors try

bors · 2021-04-30T22:01:04Z

try

Merge conflict.

jubianchi · 2021-04-30T22:28:05Z

bors try

lib/c-api/build.rs

lib/compiler-cranelift/src/config.rs

tests/compilers/wast.rs

lib/compiler-llvm/Cargo.toml

syrusakbary

Everything looks good for merging!

syrusakbary · 2021-05-15T12:09:47Z

bors try

bors · 2021-05-15T12:16:30Z

try

Build failed:

Code lint

compiler-llvm now uses the experimental.constrained intrinsics to ensure correct behavior on FP operations when full-canonicalization is disabled. This patch requires TheDan64/inkwell#247

lib/compiler-llvm/src/abi/aarch64_systemv.rs

lib/compiler-llvm/src/translator/code.rs

lib/compiler-llvm/src/translator/intrinsics.rs

Hywan

Good work!

jubianchi · 2021-05-31T13:21:40Z

bors r+

bors · 2021-05-31T14:32:46Z

Build succeeded:

jubianchi requested review from syrusakbary and nlewycky March 3, 2021 12:31

jubianchi requested review from Hywan, losfair and MarkMcCaskey as code owners March 3, 2021 12:31

bors bot added a commit that referenced this pull request Mar 3, 2021

Try #2161:

0ba6253

jubianchi force-pushed the configure-canonicalization branch from 34425fd to b8e7f25 Compare March 3, 2021 13:28

bors bot added a commit that referenced this pull request Mar 3, 2021

Try #2161:

ef8e3b0

MarkMcCaskey reviewed Mar 3, 2021

View reviewed changes

lib/c-api/src/wasm_c_api/engine.rs Outdated Show resolved Hide resolved

jubianchi force-pushed the configure-canonicalization branch from b8e7f25 to 43dbb18 Compare March 3, 2021 15:53

bors bot added a commit that referenced this pull request Mar 3, 2021

Try #2161:

9e96e62

syrusakbary reviewed Mar 3, 2021

View reviewed changes

lib/c-api/src/wasm_c_api/engine.rs Outdated Show resolved Hide resolved

syrusakbary reviewed Mar 3, 2021

View reviewed changes

lib/compiler-singlepass/src/config.rs Outdated Show resolved Hide resolved

syrusakbary reviewed Mar 3, 2021

View reviewed changes

lib/compiler/src/compiler.rs Show resolved Hide resolved

syrusakbary reviewed Mar 3, 2021

View reviewed changes

tests/ignores.txt Outdated Show resolved Hide resolved

nlewycky reviewed Mar 3, 2021

View reviewed changes

lib/compiler-llvm/src/translator/code.rs Show resolved Hide resolved

syrusakbary reviewed Apr 30, 2021

View reviewed changes

lib/compiler-llvm/src/config.rs Outdated Show resolved Hide resolved

syrusakbary reviewed Apr 30, 2021

View reviewed changes

tests/wast/wasmer/nan-canonicalization.wast Outdated Show resolved Hide resolved

jubianchi force-pushed the configure-canonicalization branch from 9eed143 to e3a3f79 Compare April 30, 2021 21:58

jubianchi force-pushed the configure-canonicalization branch from e3a3f79 to 7148402 Compare April 30, 2021 22:27

bors bot added a commit that referenced this pull request Apr 30, 2021

Try #2161:

4f4a8b1

Hywan reviewed May 4, 2021

View reviewed changes

lib/c-api/build.rs Outdated Show resolved Hide resolved

lib/compiler-cranelift/src/config.rs Show resolved Hide resolved

jubianchi force-pushed the configure-canonicalization branch 3 times, most recently from 22bf49b to c55ff44 Compare May 5, 2021 16:36

syrusakbary reviewed May 6, 2021

View reviewed changes

tests/compilers/wast.rs Outdated Show resolved Hide resolved

jubianchi force-pushed the configure-canonicalization branch from c55ff44 to 113d438 Compare May 6, 2021 20:23

syrusakbary reviewed May 6, 2021

View reviewed changes

lib/compiler-llvm/Cargo.toml Outdated Show resolved Hide resolved

syrusakbary approved these changes May 6, 2021

View reviewed changes

jubianchi force-pushed the configure-canonicalization branch from 113d438 to abebb6a Compare May 10, 2021 19:04

bors bot added a commit that referenced this pull request May 15, 2021

Try #2161:

d29920f

jubianchi force-pushed the configure-canonicalization branch from 0fe7e37 to fc4e925 Compare May 18, 2021 09:55

jubianchi changed the title ~~Make NaN canonicalization a configurable behavior~~ feat(llvm): Make NaN canonicalization configurable May 18, 2021

jubianchi force-pushed the configure-canonicalization branch from fc4e925 to 13c520b Compare May 18, 2021 09:56

jubianchi added 2 commits May 28, 2021 11:40

feat(llvm): Make NaN canonicalization configurable

6a99268

compiler-llvm now uses the experimental.constrained intrinsics to ensure correct behavior on FP operations when full-canonicalization is disabled. This patch requires TheDan64/inkwell#247

Make the code compile with latest Inkwell changes

69cf276

jubianchi force-pushed the configure-canonicalization branch from 13c520b to 69cf276 Compare May 28, 2021 16:15

Cleaning some bits

e5e51b9

MarkMcCaskey reviewed May 28, 2021

View reviewed changes

jubianchi added 2 commits May 31, 2021 11:15

Review

bb73126

cache into calls

0b119a7

jubianchi force-pushed the configure-canonicalization branch from 2836099 to 0b119a7 Compare May 31, 2021 10:26

Hywan approved these changes May 31, 2021

View reviewed changes

cargo fmt

ec1430c

bors bot merged commit c0d3a8f into master May 31, 2021

bors bot deleted the configure-canonicalization branch May 31, 2021 14:32

Hywan mentioned this pull request Jul 19, 2021

relation to wasmtime? #142

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(llvm): Make NaN canonicalization configurable #2161

feat(llvm): Make NaN canonicalization configurable #2161

jubianchi commented Mar 3, 2021 •

edited

Loading

jubianchi commented Mar 3, 2021

bors bot commented Mar 3, 2021

jubianchi commented Mar 3, 2021

bors bot commented Mar 3, 2021

jubianchi commented Mar 3, 2021

bors bot commented Mar 3, 2021

jubianchi commented Apr 30, 2021

bors bot commented Apr 30, 2021

jubianchi commented Apr 30, 2021

syrusakbary left a comment

syrusakbary commented May 15, 2021

bors bot commented May 15, 2021

Hywan left a comment

jubianchi commented May 31, 2021

bors bot commented May 31, 2021

feat(llvm): Make NaN canonicalization configurable #2161

feat(llvm): Make NaN canonicalization configurable #2161

Conversation

jubianchi commented Mar 3, 2021 • edited Loading

Review

jubianchi commented Mar 3, 2021

bors bot commented Mar 3, 2021

try

jubianchi commented Mar 3, 2021

bors bot commented Mar 3, 2021

try

jubianchi commented Mar 3, 2021

bors bot commented Mar 3, 2021

try

jubianchi commented Apr 30, 2021

bors bot commented Apr 30, 2021

try

jubianchi commented Apr 30, 2021

syrusakbary left a comment

Choose a reason for hiding this comment

syrusakbary commented May 15, 2021

bors bot commented May 15, 2021

try

Hywan left a comment

Choose a reason for hiding this comment

jubianchi commented May 31, 2021

bors bot commented May 31, 2021

jubianchi commented Mar 3, 2021 •

edited

Loading