Add wasm_config_delete to the Wasm C API
#2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubianchi
approved these changes
Jan 25, 2021
Hywan
suggested changes
Jan 26, 2021
| /// # .success(); | ||
| /// # } | ||
| /// ``` | ||
| /// cbindgen:ignore |
There was a problem hiding this comment.
Why ignoring it in the C API?
There was a problem hiding this comment.
If ignored, it won't be present in the .h files, and I don't see how the doctest can work :-).
There was a problem hiding this comment.
This is part of wasm.h , I made it ignored because wasm_config_new is also ignored and this is functionally the same
Hywan
approved these changes
Jan 26, 2021
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 1 missing import reported in #2052
This function is relatively new to the Wasm C API and its implementation is trivial