Use memmap2 in deserialize_from_file #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
force-pushed
the
memmap-load
branch
from
6bec8e2
to
e5a52f1
Compare
webmaster128
requested review from
Hywan,
MarkMcCaskey and
syrusakbary
as code owners
syrusakbary
approved these changes
Dec 14, 2020
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in CosmWasm/cosmwasm#660, we might want to use memmap in deserialize_from_file to speed up artifact loading.
This uses the fork memmap2 because https://rustsec.org/advisories/RUSTSEC-2020-0077.html
This is based on df3a211 and a CHANGELOG entry is missing, but adding it now for visibility and testing.Review