Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dynamic function envs not working with WasmerEnv #1857

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Fix dynamic function envs not working with WasmerEnv #1857

merged 2 commits into from
Dec 2, 2020

Conversation

MarkMcCaskey
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey commented Dec 2, 2020 •
edited
Loading

Review

  • Add a short description of the the change to the CHANGELOG.md file

syrusakbary
syrusakbary reviewed Dec 2, 2020
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be good to merge once a test is added

@syrusakbary syrusakbary merged commit 11bf406 into master Dec 2, 2020
@bors bors bot deleted the fix/dynamic-fn-env-wasmer-env branch December 2, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@Hywan Hywan Awaiting requested review from Hywan

@nlewycky nlewycky Awaiting requested review from nlewycky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkMcCaskey @syrusakbary