Fix issue with path_rename moving down 1 directory
#1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add test? |
Yeah been working on it, but as I said, it's not easily observable from inside our WASI system. I think I've probably found a way to test it though |
Hywan
approved these changes
Oct 27, 2020
jubianchi
approved these changes
Oct 30, 2020
bf069e946 Update path rename WASI test to ensure that things work as expected dd93cb4d6 Clarify that `wasm-opt` comes from binaryen git-subtree-dir: tests/wasi-wast git-subtree-split: bf069e94621d6a72cdcaf5e30844cdbe19b75530
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1759
Due to file metadata caching in WasiFS this behavior isn't easily observable with tests because as far as the rest of the WASI calls are concerned the file is in the right place:
perhaps we should consider removing some of that caching, but it's a large change and may have other implications...
Ideally we do want to not be dependent on the file system when dealing with open files... the issue here is that when we rename it, we still consider it to be a file that WasiFS is actively managing. This maybe relatively easy to fix on its own
Review