Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(c-api): Implement wasm_global_type #1736

Merged
merged 1 commit into from
Oct 19, 2020
Merged

feat(c-api): Implement wasm_global_type #1736

merged 1 commit into from
Oct 19, 2020

Conversation

jubianchi
Copy link
Contributor

@jubianchi jubianchi commented Oct 19, 2020 •
edited
Loading

This patch adds a wasm_globaltype_t::new constructor for use by the
new wasm_global_type function and the existing
wasm_globaltype_new_inner function.

Note: wasm_global_type is defined here:

wasmer/lib/c-api/tests/wasm_c_api/wasm-c-api/include/wasm.h

Line 436 in 193d7c8

WASM_API_EXTERN own wasm_globaltype_t* wasm_global_type(const wasm_global_t*);

Review

  • Add a short description of the the change to the CHANGELOG.md file

@jubianchi jubianchi added 🎉 enhancement New feature! 📦 lib-c-api About wasmer-c-api labels Oct 19, 2020
@jubianchi jubianchi requested a review from Hywan as a code owner October 19, 2020 13:23
@jubianchi jubianchi mentioned this pull request Oct 19, 2020
Merged
5 tasks
Hywan
Hywan approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Update the CHANGELOG and go :-).

@Hywan
Copy link
Contributor

Hywan commented Oct 19, 2020

bors try

bors bot added a commit that referenced this pull request Oct 19, 2020
@bors
Try #1736:
3934275
@bors
Copy link
Contributor

bors bot commented Oct 19, 2020

try

Build failed:

@jubianchi
feat(c-api): Implement wasm_global_type
5c26a81 
This patch adds a `wasm_globaltype_t::new` constructor for use by the
new `wasm_global_type` function and the existing
`wasm_globaltype_new_inner` function.

Note: `wasm_global_type` is defined here:
https://github.com/wasmerio/wasmer/blob/193d7c8ce1b744e6078269ac7a77dd53d1e4cbd6/lib/c-api/tests/wasm_c_api/wasm-c-api/include/wasm.h#L436
@jubianchi
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Oct 19, 2020
@bors
Try #1736:
c9a4852
@bors
Copy link
Contributor

bors bot commented Oct 19, 2020

try

Build succeeded:

@Hywan
Copy link
Contributor

Hywan commented Oct 19, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 19, 2020

Build succeeded:

@bors bors bot merged commit a1ccfe2 into wasmerio:master Oct 19, 2020
@jubianchi jubianchi deleted the c-api/wasm_global_type branch October 19, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hywan Hywan Hywan approved these changes

Assignees
No one assigned
Labels
🎉 enhancement New feature! 📦 lib-c-api About wasmer-c-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jubianchi @Hywan