Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the minimum rust version to 1.45.2. #1554

Merged
merged 5 commits into from
Aug 19, 2020
Merged

Bump the minimum rust version to 1.45.2. #1554

merged 5 commits into from
Aug 19, 2020

Conversation

nlewycky
Copy link
Contributor

Description

Bump the minimum required rustc version to 1.45.2, marking the first time that singlepass will be able to build without a nightly compiler.

This is a bit ahead of schedule (we normally support one behind the most recent stable) but we expect the next stable to be released in about a week, which should happen before this commit is released.

Review

  • Add a short description of the the change to the CHANGELOG.md file

Copy link
Contributor

@MarkMcCaskey MarkMcCaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I think we also need to update the singlepass dyn asm dep (and Cargo.lock) for this to work on stable

@nlewycky nlewycky requested a review from losfair as a code owner August 18, 2020 23:38
@nlewycky
Copy link
Contributor Author

Looks good to me, but I think we also need to update the singlepass dyn asm dep (and Cargo.lock) for this to work on stable

Done!

@nlewycky
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Aug 18, 2020
1554: Bump the minimum rust version to 1.45.2. r=nlewycky a=nlewycky

# Description
Bump the minimum required rustc version to 1.45.2, marking the first time that singlepass will be able to build without a nightly compiler.

This is a bit ahead of schedule (we normally support one behind the most recent stable) but we expect the next stable to be released in about a week, which should happen before this commit is released.

# Review

- [ ] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: Nick Lewycky <nicholas@mxc.ca>
@bors
Copy link
Contributor

bors bot commented Aug 18, 2020

Canceled.

@nlewycky
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Aug 18, 2020
1554: Bump the minimum rust version to 1.45.2. r=nlewycky a=nlewycky

# Description
Bump the minimum required rustc version to 1.45.2, marking the first time that singlepass will be able to build without a nightly compiler.

This is a bit ahead of schedule (we normally support one behind the most recent stable) but we expect the next stable to be released in about a week, which should happen before this commit is released.

# Review

- [ ] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: Nick Lewycky <nicholas@mxc.ca>
@bors
Copy link
Contributor

bors bot commented Aug 19, 2020

Canceled.

@nlewycky
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 19, 2020

Build succeeded:

  • wasmerio.wasmer

@bors bors bot merged commit 15e615b into 0.x Aug 19, 2020
@bors bors bot deleted the feature/0.x-minrustc branch August 19, 2020 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants