Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new features to WasiState builder API #1170

Merged
merged 4 commits into from
Jan 22, 2020
Merged

Add new features to WasiState builder API #1170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1cadf9
Add new features to WasiState builder API
Jan 22, 2020
7ea6943
Update example in doc to use new preopened dir builder
Jan 22, 2020
19ea53b
Update lib/wasi/src/state/builder.rs
MarkMcCaskey Jan 22, 2020
4862828
Clean up and add another example
Jan 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## **[Unreleased]**

- [#1170](https://github.com/wasmerio/wasmer/pull/1170) Improve the WasiFs builder API with convenience methods for overriding stdin, stdout, and stderr as well as a new sub-builder for controlling the permissions and properties of preopened directories. Also breaks that implementations of `WasiFile` must be `Send` -- please file an issue if this change causes you any issues.
- [#1161](https://github.com/wasmerio/wasmer/pull/1161) Require imported functions to be `Send`. This is a breaking change that fixes a soundness issue in the API.
- [#1129](https://github.com/wasmerio/wasmer/pull/1129) Standard exception types for singlepass backend.
- [#1140](https://github.com/wasmerio/wasmer/pull/1140) Use [`blake3`](https://github.com/BLAKE3-team/BLAKE3) as default hashing algorithm for caching.
Expand Down
4 changes: 4 additions & 0 deletions lib/wasi/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ pub fn generate_import_object(
let preopened_files = preopened_files.clone();
let mapped_dirs = mapped_dirs.clone();

// this deprecation warning only applies to external callers
#[allow(deprecated)]
let state = Box::new(WasiState {
fs: WasiFs::new(&preopened_files, &mapped_dirs).expect("Could not create WASI FS"),
args: args.clone(),
Expand Down Expand Up @@ -150,6 +152,8 @@ fn generate_import_object_snapshot0(
let mapped_dirs = mapped_dirs.clone();
//let wasi_builder = create_wasi_instance();

// this deprecation warning only applies to external callers
#[allow(deprecated)]
let state = Box::new(WasiState {
fs: WasiFs::new(&preopened_files, &mapped_dirs).expect("Could not create WASI FS"),
args: args.clone(),
Expand Down
Loading