Standard exception types for singlepass backend. #1129

losfair · 2020-01-09T18:56:48Z

No description provided.

…eptions

losfair · 2020-01-09T19:07:19Z

bors try

bors · 2020-01-09T19:56:57Z

try

Build succeeded

continuous-integration/travis-ci/push
wasmerio.wasmer

…eptions

Hywan

Thanks for adding more comments in the code!

The code looks good to me.

Hywan · 2020-01-13T14:50:06Z

lib/runtime-core/src/error.rs

@@ -208,6 +209,8 @@ impl std::fmt::Display for RuntimeError {
                    write!(f, "\"{}\"", s)
                } else if let Some(s) = data.downcast_ref::<&str>() {
                    write!(f, "\"{}\"", s)
+                } else if let Some(exc_code) = data.downcast_ref::<ExceptionCode>() {
+                    write!(f, "\"{:?}\"", exc_code)


Maybe we should write it is an exception code, so that the user has more insight than the variant name. My suggestion:

write!(f, "exception code \"{:?}\"", exc_code)

Thanks! Fixed and now the error message looks like Error: RuntimeError: Caught exception of type "Arithmetic"..

…eptions

nlewycky

This looks really good. Thank you!!

The goal was to fix some of the spectests that are excluded from singlepass due to not failing "the right way". I don't see any updates to excludes.txt. Are those fixed?

…eptions

losfair · 2020-01-15T19:06:07Z

@nlewycky I just updated excludes.txt and removed most singlepass excludes., but there are still a few failures related to linking.wast. I'm not really sure what's going on there.

By the way, I think it would be good to refactor RuntimeError and remove the Any box (and make ExceptionCode a variant + remove plain strings) - maybe in a future PR.

syrusakbary · 2020-01-16T11:05:33Z

bors r+

1129: Standard exception types for singlepass backend. r=syrusakbary a=losfair Co-authored-by: losfair <zhy20000919@hotmail.com>

bors · 2020-01-16T11:12:11Z

Build failed

continuous-integration/travis-ci/push

…eptions

losfair · 2020-01-20T18:09:08Z

bors r+

1129: Standard exception types for singlepass backend. r=losfair a=losfair Co-authored-by: losfair <zhy20000919@hotmail.com>

losfair · 2020-01-20T18:20:00Z

bors r-

bors · 2020-01-20T18:20:01Z

Canceled

…eptions

losfair · 2020-01-20T18:22:33Z

bors r+

1129: Standard exception types for singlepass backend. r=losfair a=losfair Co-authored-by: losfair <zhy20000919@hotmail.com>

bors · 2020-01-20T18:47:45Z

Build succeeded

continuous-integration/travis-ci/push
wasmerio.wasmer

lexfrl · 2020-02-05T16:24:51Z

Great job! I have a small question: why these traps are RuntimeError::Error? Shouldn't it be a RuntimeError::Trap?

1192: Use `ExceptionCode` for error representation. r=losfair a=losfair Extends #1129 to all backends. Co-authored-by: losfair <zhy20000919@hotmail.com>

losfair added 6 commits January 9, 2020 01:42

ExceptionCode and ExceptionTable.

5c15ff9

Look up exception tables in trap handler.

f44517b

Serialize/deserialize exception codes.

4b5b897

Push code version for non-WASI entrypoints.

8bf0c19

Emit exception table in singlepass.

0a23327

Run cargo fmt.

9e2080d

losfair requested review from bjfish, Hywan, MarkMcCaskey, nlewycky and syrusakbary as code owners January 9, 2020 18:56

Merge remote-tracking branch 'origin/master' into feature/unified-exc…

10da5ba

…eptions

bors bot added a commit that referenced this pull request Jan 9, 2020

Try #1129:

90d32ab

losfair added 2 commits January 13, 2020 22:36

Merge remote-tracking branch 'origin/master' into feature/unified-exc…

42e5e78

…eptions

Fix type of backend passed to push_code_version.

f4fb107

Hywan approved these changes Jan 13, 2020

View reviewed changes

Hywan added 🎉 enhancement New feature! 📦 lib-compiler-singlepass About wasmer-compiler-singlepass labels Jan 13, 2020

Hywan self-assigned this Jan 13, 2020

losfair added 2 commits January 14, 2020 20:47

Merge remote-tracking branch 'origin/master' into feature/unified-exc…

a45cbd6

…eptions

Improve error message on exception.

6dfd591

nlewycky reviewed Jan 15, 2020

View reviewed changes

losfair added 3 commits January 16, 2020 02:59

Update spectests to test singlepass traps.

35870b3

Merge remote-tracking branch 'origin/master' into feature/unified-exc…

1b3e679

…eptions

Merge remote-tracking branch 'origin/master' into feature/unified-exc…

d3ebb5f

…eptions

nlewycky approved these changes Jan 15, 2020

View reviewed changes

bors bot added a commit that referenced this pull request Jan 16, 2020

Merge #1129

7a76f32

1129: Standard exception types for singlepass backend. r=syrusakbary a=losfair Co-authored-by: losfair <zhy20000919@hotmail.com>

losfair added 3 commits January 21, 2020 01:10

Add aarch64-specific failure excludes.

16dee04

Merge remote-tracking branch 'origin/master' into feature/unified-exc…

74eb113

…eptions

Fix backend string type.

dc21636

bors bot added a commit that referenced this pull request Jan 20, 2020

Merge #1129

d2ff7b6

1129: Standard exception types for singlepass backend. r=losfair a=losfair Co-authored-by: losfair <zhy20000919@hotmail.com>

losfair added 2 commits January 21, 2020 02:20

Merge remote-tracking branch 'origin/master' into feature/unified-exc…

5266116

…eptions

Update changelog.

1b5d9f2

bors bot added a commit that referenced this pull request Jan 20, 2020

Merge #1129

d73d837

1129: Standard exception types for singlepass backend. r=losfair a=losfair Co-authored-by: losfair <zhy20000919@hotmail.com>

bors bot merged commit 1b5d9f2 into master Jan 20, 2020

bors bot deleted the feature/unified-exceptions branch January 20, 2020 18:47

MaksymZavershynskyi mentioned this pull request Jan 23, 2020

Fix FunctionCallError(WasmTrap("unknown")) near/nearcore#2009

Closed

losfair mentioned this pull request Feb 6, 2020

Use ExceptionCode for error representation. #1192

Merged

bors bot added a commit that referenced this pull request Feb 10, 2020

Merge #1192

ab059ff

1192: Use `ExceptionCode` for error representation. r=losfair a=losfair Extends #1129 to all backends. Co-authored-by: losfair <zhy20000919@hotmail.com>

bors bot added a commit that referenced this pull request Feb 10, 2020

Merge #1192

004dadc

1192: Use `ExceptionCode` for error representation. r=losfair a=losfair Extends #1129 to all backends. Co-authored-by: losfair <zhy20000919@hotmail.com>

bors bot added a commit that referenced this pull request Feb 10, 2020

Merge #1192

92f2628

1192: Use `ExceptionCode` for error representation. r=losfair a=losfair Extends #1129 to all backends. Co-authored-by: losfair <zhy20000919@hotmail.com>

bors bot added a commit that referenced this pull request Feb 11, 2020

Merge #1192

eaa081e

1192: Use `ExceptionCode` for error representation. r=losfair a=losfair Extends #1129 to all backends. Co-authored-by: losfair <zhy20000919@hotmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Standard exception types for singlepass backend. #1129

Standard exception types for singlepass backend. #1129

losfair commented Jan 9, 2020

losfair commented Jan 9, 2020

bors bot commented Jan 9, 2020

Hywan left a comment

Hywan Jan 13, 2020

losfair Jan 14, 2020

nlewycky left a comment

losfair commented Jan 15, 2020

syrusakbary commented Jan 16, 2020

bors bot commented Jan 16, 2020

losfair commented Jan 20, 2020

losfair commented Jan 20, 2020

bors bot commented Jan 20, 2020

losfair commented Jan 20, 2020

bors bot commented Jan 20, 2020

lexfrl commented Feb 5, 2020

Standard exception types for singlepass backend. #1129

Standard exception types for singlepass backend. #1129

Conversation

losfair commented Jan 9, 2020

losfair commented Jan 9, 2020

bors bot commented Jan 9, 2020

try

Build succeeded

Hywan left a comment

Choose a reason for hiding this comment

Hywan Jan 13, 2020

Choose a reason for hiding this comment

losfair Jan 14, 2020

Choose a reason for hiding this comment

nlewycky left a comment

Choose a reason for hiding this comment

losfair commented Jan 15, 2020

syrusakbary commented Jan 16, 2020

bors bot commented Jan 16, 2020

Build failed

losfair commented Jan 20, 2020

losfair commented Jan 20, 2020

bors bot commented Jan 20, 2020

Canceled

losfair commented Jan 20, 2020

bors bot commented Jan 20, 2020

Build succeeded

lexfrl commented Feb 5, 2020