Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasi: Memory Leak due to Cyclical WasiControlPlane References #3642

Closed
theduke opened this issue Mar 5, 2023 · 0 comments · Fixed by #3643
Closed

wasi: Memory Leak due to Cyclical WasiControlPlane References #3642

theduke opened this issue Mar 5, 2023 · 0 comments · Fixed by #3643
Assignees
@theduke
Labels
bug Something isn't working 📦 lib-wasi About wasmer-wasi

Comments

@theduke
Copy link
Contributor

theduke commented Mar 5, 2023

WasiProcess holds WasiControlPlane which holds all WasiProcesses...
@theduke theduke added bug Something isn't working 📦 lib-wasi About wasmer-wasi labels Mar 5, 2023
@theduke theduke self-assigned this Mar 5, 2023
This was referenced Mar 5, 2023
Closed
Merged
theduke added a commit that referenced this issue Mar 5, 2023
@theduke
fix(wasi): Memory leak due to cyclical WasiControlPlane references
5ff0733 
Fixed by WasiProcess just storing a Weak<> handle to the control plane.

Note: This could/should also be changed so that the WasiProcess does not
have a handle to the control plane at all, but that requires some
slightly bigger refactoring that also changes or removes the SignalHandlerAbi

Closes #3642
theduke added a commit that referenced this issue Mar 6, 2023
@theduke
fix(wasi): Memory leak due to cyclical WasiControlPlane references
984b9a3 
Fixed by WasiProcess just storing a Weak<> handle to the control plane.

Note: This could/should also be changed so that the WasiProcess does not
have a handle to the control plane at all, but that requires some
slightly bigger refactoring that also changes or removes the SignalHandlerAbi

Closes #3642
theduke added a commit that referenced this issue Mar 6, 2023
@theduke
fix(wasi): Memory leak due to cyclical WasiControlPlane references
b761c82 
Fixed by WasiProcess just storing a Weak<> handle to the control plane.

Note: This could/should also be changed so that the WasiProcess does not
have a handle to the control plane at all, but that requires some
slightly bigger refactoring that also changes or removes the SignalHandlerAbi

Closes #3642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theduke theduke

Labels
bug Something isn't working 📦 lib-wasi About wasmer-wasi
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(wasi): Memory leak due to cyclical WasiControlPlane references wasmerio/wasmer
1 participant
@theduke