Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport Singlepass optimisations from Near #3305

Closed
ptitSeb opened this issue Nov 15, 2022 · 2 comments
Closed

Backport Singlepass optimisations from Near #3305

ptitSeb opened this issue Nov 15, 2022 · 2 comments
Assignees
@ptitSeb
Labels
⚙️ feature request priority-medium Medium priority issue
Milestone
v3.1

Comments

@ptitSeb
Copy link
Contributor

ptitSeb commented Nov 15, 2022 •
edited
Loading

Check if latest optimisation on the fork of the Singlepass compiler from Near can be backported to Wasmer.
@ptitSeb ptitSeb self-assigned this Nov 15, 2022
@ptitSeb ptitSeb added this to the v3.x milestone Nov 15, 2022
@ptitSeb
Copy link
Contributor Author

ptitSeb commented Nov 15, 2022 •
edited
Loading

near/wasmer#147 => already there
near/wasmer#145 => #3302
near/wasmer#144 => #3296
near/wasmer#143 => #3293
near/wasmer#141 => #3292
near/wasmer#140 => #3290
near/wasmer#136 => not applicable as-is. Locals are simple Vec<> in Wasmer, while it's a Partial_sum_map on Near, probably to save memory.

This was referenced Nov 15, 2022
Merged
Merged
Merged
Merged
Merged
@ptitSeb ptitSeb modified the milestones: v3.x, v3.1 Nov 16, 2022
bors bot added a commit that referenced this issue Nov 21, 2022
@bors @ptitSeb
Merge #3290
d4d2d10 
3290: Limit the use of clone when handling Compilation object r=ptitSeb a=ptitSeb

# Description
Small improvment to limit the number of clone when handling Compilation object.

Based on near/wasmer#140

For #3305 

Co-authored-by: ptitSeb <sebastien.chev@gmail.com>
bors bot added a commit that referenced this issue Nov 21, 2022
@bors @ptitSeb
Merge #3292
1b15406 
3292: Precompute offsets in VMOffsets r=ptitSeb a=ptitSeb

# Description
Small optimisation: Precompute Offsets in VMOffsets

based on near/wasmer#141

For #3305

Co-authored-by: ptitSeb <sebastien.chev@gmail.com>
bors bot added a commit that referenced this issue Nov 21, 2022
@bors @ptitSeb
Merge #3296
71a2761 
3296: Use the right collection when parsing type section r=ptitSeb a=ptitSeb

# Description
Use the right collection when parsing type section

based on near/wasmer#144

For #3305 

Co-authored-by: ptitSeb <sebastien.chev@gmail.com>
bors bot added a commit that referenced this issue Nov 22, 2022
@bors @ptitSeb
Merge #3302
0928629 
3302: Some Refactor of Singlepass compiler to have better error and cpu features handling r=ptitSeb a=ptitSeb

# Description

* Some refactor of Singlepass compiler to have a better handling of Target CPU Feature and Error propagation
* Added support for TZCNT and LZCNT opcode on x86_64 backend (based on near/wasmer#145)
For #3305 

Co-authored-by: ptitSeb <sebastien.chev@gmail.com>
@Michael-F-Bryan Michael-F-Bryan added the priority-medium Medium priority issue label Nov 29, 2022
@Michael-F-Bryan
Copy link
Contributor

All these optimisations should be implemented now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptitSeb ptitSeb

Labels
⚙️ feature request priority-medium Medium priority issue
Projects
None yet
Milestone
v3.1
Development

No branches or pull requests
2 participants
@ptitSeb @Michael-F-Bryan