Skip to content

Commit

Permalink
tests: Disable two flaky snapshot tests
Browse files Browse the repository at this point in the history
  • Loading branch information
theduke committed Mar 13, 2023
1 parent dbacbb9 commit 7bc3a11
Showing 1 changed file with 18 additions and 16 deletions.
34 changes: 18 additions & 16 deletions tests/integration/cli/tests/snapshot.rs
Original file line number Diff line number Diff line change
Expand Up @@ -303,16 +303,17 @@ fn test_snapshot_cowsay() {
// assert_json_snapshot!(snapshot);
// }

// FIXME: re-enable, disabled due to flakyness
// The ability to fork the current process and run a different image but retain
// the existing open file handles (which is needed for stdin and stdout redirection)
#[cfg(not(target_os = "windows"))]
#[test]
fn test_snapshot_fork_and_exec() {
let snapshot = TestBuilder::new()
.use_coreutils()
.run_wasm(include_bytes!("./wasm/example-execve.wasm"));
assert_json_snapshot!(snapshot);
}
// #[cfg(not(target_os = "windows"))]
// #[test]
// fn test_snapshot_fork_and_exec() {
// let snapshot = TestBuilder::new()
// .use_coreutils()
// .run_wasm(include_bytes!("./wasm/example-execve.wasm"));
// assert_json_snapshot!(snapshot);
// }

// longjmp is used by C programs that save and restore the stack at specific
// points - this functionality is often used for exception handling
Expand Down Expand Up @@ -379,15 +380,16 @@ fn test_snapshot_sleep() {
assert_json_snapshot!(snapshot);
}

// FIXME: re-enable, disabled due to flakyness
// Uses `posix_spawn` to launch a sub-process and wait on it to exit
#[cfg(not(target_os = "windows"))]
#[test]
fn test_snapshot_process_spawn() {
let snapshot = TestBuilder::new()
.use_coreutils()
.run_wasm(include_bytes!("./wasm/example-spawn.wasm"));
assert_json_snapshot!(snapshot);
}
// #[cfg(not(target_os = "windows"))]
// #[test]
// fn test_snapshot_process_spawn() {
// let snapshot = TestBuilder::new()
// .use_coreutils()
// .run_wasm(include_bytes!("./wasm/example-spawn.wasm"));
// assert_json_snapshot!(snapshot);
// }

// FIXME: re-enable - hangs on windows and macos
// Connects to 8.8.8.8:53 over TCP to verify TCP clients work
Expand Down

0 comments on commit 7bc3a11

Please sign in to comment.