This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
yordis/feat add env var for websocket host #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes wasmCloud#741 Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/feat-add-env-var-for-websocket-host
branch
from
4312912
to
54d9386
Compare
yordis
requested review from
autodidaddict,
brooksmtownsend and
thomastaylor312
as code owners
yordis
force-pushed
the
yordis/feat-add-env-var-for-websocket-host
branch
from
54d9386
to
8c9a011
Compare
There was a problem hiding this comment.
This looks fine to me, would like @lachieh's opinion just to make sure I'm not missing anything
lachieh
suggested changes
Aug 30, 2023
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/feat-add-env-var-for-websocket-host
branch
from
8c9a011
to
98e93b3
Compare
lachieh
approved these changes
Aug 30, 2023
connorsmith256
approved these changes
Aug 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.