This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
feat: add preview2 target to wasmcloud.toml #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vados-cosmonic
requested review from
autodidaddict,
brooksmtownsend and
thomastaylor312
as code owners
vados-cosmonic
changed the title
brooksmtownsend
previously approved these changes
Jul 6, 2023
|
Welp, a new test seems to be failing:
So going to look into that too. |
brooksmtownsend
previously approved these changes
Jul 7, 2023
ricochet
previously approved these changes
Jul 7, 2023
|
Hey @ricochet just to update you here -- dealing with an GHA and/or elixir issue when starting up
Trying to cycle it before the unit tests run to avoid this happening during the test(s). |
brooksmtownsend
previously approved these changes
Jul 7, 2023
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
brooksmtownsend
approved these changes
Jul 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
Add a more explicit WASI target to wasmcloud.toml configuration, in preparation for building in support for adding post-build support for preview2 components.
Related Issues
#640
Release Information
nextConsumer Impact
Customers will be able to specify
wasm32-wasi-preview2to target a wasm32-wasi-preview buildTesting
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Acceptance or Integration
Tests with different configuration options were added
Manual Verification
This was tested locally by:
wash buildwithwasm_target=wasm32-unknown-unknownwash buildwithwasm_target=wasm32-wasiwash buildwithwasm_target=wasm32-wasi-preview1wash buildwithwasm_target=wasm32-wasi-preview2(errored as expected)