This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
fix(up): the wadm pidfile is not removed when wadm is not started #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
Iceber
requested review from
autodidaddict,
brooksmtownsend and
thomastaylor312
as code owners
brooksmtownsend
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Great fix @Iceber ! Thank you for filing the issue and then taking care of it 🚀
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
The pidfile file may have been created by another
wash up.Also, this pr ignores the case that the pidfile does not exist when it is removed, and the file should not cause a failure if it does not exist
Related Issues
fix: #634
Release Information
Consumer Impact
Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Acceptance or Integration
Manual Verification