feat(ux): flatten ctl link query claims inventory

[vados-cosmonic]

Feature or Problem

⚠️ This PR should be merged after #580

Merge wash ctl link query, wash ctl get claims and wash ctl get inventory into a single wash get command

See:

• [RFC] wash command structure rework #538

Related Issues

Release Information

next

Consumer Impact

Users should be able to more quickly and conveniently access information about the cluster in fewer keystrokes with wash get rather than wash ctl link query (and similar commands).

Testing

Built on platform(s)

• x86_64-linux
• aarch64-linux
• x86_64-darwin
• aarch64-darwin
• x86_64-windows

Tested on platform(s)

• x86_64-linux
• aarch64-linux
• x86_64-darwin
• aarch64-darwin
• x86_64-windows

Unit Test(s)

Acceptance or Integration

Integration tests were added for the new top level commands (see integration_get.rs), and the existing tests continue to pass for older CLI commands.

Manual Verification

[vados-cosmonic]

Looks like there is a flaky test -- not any of the new added ones, but while I'm here I'd like to investigate it

[connorsmith256]

LGTM. I can merge as-is or hold if you're still looking into the flaky test 👍

[vados-cosmonic]

Yeah I'm still sus about this one failure -- I want to see if I can reproduce it in my own fork after running it a few times.

[vados-cosmonic]

Yeah so a bunch of tests are leaky (nextest is awesome!):

        LEAK [  26.120s] wash-cli::integration_get integration_get_claims
        LEAK [  16.044s] wash-cli::integration_get integration_get_host_inventory
        LEAK [  16.559s] wash-cli::integration_get integration_get_hosts
        LEAK [  13.734s] wash-cli::integration_get integration_get_links
        LEAK [  13.701s] wash-cli::integration_link integration_link
        LEAK [  17.404s] wash-cli::integration_start integration_start_actor
         LEAK [  19.604s] wash-cli::integration_start integration_start_provider
        LEAK [  11.569s] wash-cli::integration_stop integration_stop_host
        LEAK [  14.827s] wash-cli::integration_stop integration_stop_provider        

Something related to starting/stopping the processes. I think it might be wash() starting a std::process::Command instead of a tokio one... so that might be a somewhat deep change, because wash() is used in non-async contexts all over the place

[vados-cosmonic]

Finally found the issue -- nextest does not seem to support interop with serial_test... I've been using #[serial], and I'm fairly certain it does nothing right now when we run with nextest. The fix was to modify how we were using nextest's serial functionality a little bit so we can more easily use it. No more leaky tests!

Seems to have exposed some issues with other tests so dealing with that...

[brooksmtownsend]

Nice!