This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Renamed windows set_keys util function #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
brooksmtownsend
requested review from
autodidaddict,
stevelr and
thomastaylor312
as code owners
autodidaddict
previously approved these changes
Jan 18, 2022
autodidaddict
previously approved these changes
Jan 18, 2022
Signed-off-by: Brooks Townsend <brooks@cosmonic.com> changed param type, updated action Signed-off-by: Brooks Townsend <brooks@cosmonic.com> added services instead of docker-compose Signed-off-by: Brooks Townsend <brooks@cosmonic.com> setup docker to match windows version Signed-off-by: Brooks Townsend <brooks@cosmonic.com> try docker compose action Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com> detach docker compose Signed-off-by: Brooks Townsend <brooks@cosmonic.com> fixed _ to - Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
brooksmtownsend
force-pushed
the
fix/windows-util
branch
from
f80102c
to
31df2f2
Compare
|
@autodidaddict apologies for the continued requested reviews, keeps dismissing the approval when I change a minor thing (I thought the tests would pass last time) |
autodidaddict
approved these changes
Jan 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed a util function for windows that caused a compilation error. Bumped a patch version to compensate, and also added a matrix of OS'es so we can ensure we don't run into this again.