-
Notifications
You must be signed in to change notification settings - Fork 57
fix/feat: add cfg
module to get or create the .wash
directory
#216
fix/feat: add cfg
module to get or create the .wash
directory
#216
Conversation
Signed-off-by: Matt Wilkinson <mattwilki17@gmail.com>
980ea1f
to
3c37147
Compare
cfg
module to get/create the .wash
directorycfg
module to get/create the .wash
directory
cfg
module to get/create the .wash
directorycfg
module to get or create the .wash
directory
Follow up question @brooksmtownsend - Why do we have separate environment variables for each part of the config directory? Like My thinking is that if we then add more configuration options, users would have to maintain tons of environment variables if they wanted to customize where the config is stored, vs just setting a single one and calling it a day. |
Signed-off-by: Matt Wilkinson <mattwilki17@gmail.com>
Signed-off-by: Matt Wilkinson <mattwilki17@gmail.com>
Signed-off-by: Matt Wilkinson <mattwilki17@gmail.com>
The main reason here was that someone could feasibly set I think there's three possible scenarios for someone configuring wash
We currently support all three options with |
Ok that makes sense! Perhaps could revisit this if it becomes an issue later. |
I've removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you again @mattwilkinsonn !
Fixes #215.
Currently if the
.wash
folder does not already exist, thectx
commands fail. This PR adds acfg
module along with acfg_dir
function that gets the.wash
directory, and creates it if it does not exist.This will need to be added to all of the functions that use the
.wash
directory. That looks likekeys.rs
and a few other ones inctx
. I'll implement these after getting a review on this design and any feedback you guys have.