This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 57
feat(ctl): warning if contract IDs look like an nkey #214
Merged
brooksmtownsend
merged 2 commits into
wasmCloud:main
from
matthewtgilbride:feature/hint-for-mistaken-inputs
Jan 4, 2022
Merged
feat(ctl): warning if contract IDs look like an nkey #214
brooksmtownsend
merged 2 commits into
wasmCloud:main
from
matthewtgilbride:feature/hint-for-mistaken-inputs
Jan 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewtgilbride
force-pushed
the
feature/hint-for-mistaken-inputs
branch
2 times, most recently
from
December 8, 2021 22:34
24de767
to
abc9a55
Compare
brooksmtownsend
suggested changes
Dec 9, 2021
matthewtgilbride
force-pushed
the
feature/hint-for-mistaken-inputs
branch
from
December 12, 2021 17:11
abc9a55
to
fa85778
Compare
matthewtgilbride
changed the title
feat(ctl): warning if contract ID looks like an nkey
feat(ctl): warning if link put contract ID looks like an nkey
Dec 12, 2021
matthewtgilbride
requested review from
autodidaddict,
stevelr and
thomastaylor312
as code owners
December 12, 2021 17:12
matthewtgilbride
force-pushed
the
feature/hint-for-mistaken-inputs
branch
2 times, most recently
from
December 12, 2021 17:28
fd21bd2
to
736d44b
Compare
matthewtgilbride
changed the title
feat(ctl): warning if link put contract ID looks like an nkey
feat(ctl): warning if contract IDs look like an nkey
Dec 12, 2021
brooksmtownsend
suggested changes
Dec 13, 2021
Signed-off-by: matthewtgilbride <matthewtgilbride@gmail.com>
matthewtgilbride
force-pushed
the
feature/hint-for-mistaken-inputs
branch
from
December 27, 2021 20:59
7d2cb12
to
bf094ad
Compare
@brooksmtownsend apologies for the holiday delay 🌲 - have a look when you have another chance. |
Current build failure (test fail):
|
matthewtgilbride
force-pushed
the
feature/hint-for-mistaken-inputs
branch
from
December 28, 2021 15:19
56633c9
to
e833e88
Compare
Signed-off-by: matthewtgilbride <matthewtgilbride@gmail.com>
matthewtgilbride
force-pushed
the
feature/hint-for-mistaken-inputs
branch
from
December 28, 2021 15:20
e833e88
to
a4d3716
Compare
fixed |
autodidaddict
approved these changes
Jan 4, 2022
brooksmtownsend
approved these changes
Jan 4, 2022
Thanks @matthewtgilbride ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #188