Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

feat(ctl): warning if contract IDs look like an nkey #214

Conversation

matthewtgilbride
Copy link
Contributor

@matthewtgilbride matthewtgilbride commented Dec 8, 2021

closes #188

@matthewtgilbride matthewtgilbride force-pushed the feature/hint-for-mistaken-inputs branch 2 times, most recently from 24de767 to abc9a55 Compare December 8, 2021 22:34
src/ctl/mod.rs Outdated Show resolved Hide resolved
@matthewtgilbride matthewtgilbride changed the title feat(ctl): warning if contract ID looks like an nkey feat(ctl): warning if link put contract ID looks like an nkey Dec 12, 2021
@matthewtgilbride matthewtgilbride marked this pull request as ready for review December 12, 2021 17:12
@matthewtgilbride matthewtgilbride force-pushed the feature/hint-for-mistaken-inputs branch 2 times, most recently from fd21bd2 to 736d44b Compare December 12, 2021 17:28
@matthewtgilbride matthewtgilbride changed the title feat(ctl): warning if link put contract ID looks like an nkey feat(ctl): warning if contract IDs look like an nkey Dec 12, 2021
src/ctl/mod.rs Outdated Show resolved Hide resolved
src/ctl/mod.rs Outdated Show resolved Hide resolved
src/ctl/mod.rs Outdated Show resolved Hide resolved
src/ctl/mod.rs Outdated Show resolved Hide resolved
src/ctl/mod.rs Outdated Show resolved Hide resolved
Signed-off-by: matthewtgilbride <matthewtgilbride@gmail.com>
@matthewtgilbride
Copy link
Contributor Author

@brooksmtownsend apologies for the holiday delay 🌲 - have a look when you have another chance.

@autodidaddict
Copy link
Member

autodidaddict commented Dec 27, 2021

Current build failure (test fail):

    --> src/call.rs:399:17
    |
399 |                 assert_eq!(actor_id, ACTOR_ID);
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `Id`, found `&str`
    |
    = note: expected struct `Id<'M'>`
            found reference `&str`
    = note: this error originates in the macro `assert_eq` (in Nightly builds, run with -Z macro-backtrace for more info)

Signed-off-by: matthewtgilbride <matthewtgilbride@gmail.com>
@matthewtgilbride
Copy link
Contributor Author

Current build failure (test fail):

    --> src/call.rs:399:17
    |
399 |                 assert_eq!(actor_id, ACTOR_ID);
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `Id`, found `&str`
    |
    = note: expected struct `Id<'M'>`
            found reference `&str`
    = note: this error originates in the macro `assert_eq` (in Nightly builds, run with -Z macro-backtrace for more info)

fixed

@brooksmtownsend brooksmtownsend merged commit 4e16308 into wasmCloud:main Jan 4, 2022
@brooksmtownsend
Copy link
Member

Thanks @matthewtgilbride !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] validation of wash link put arguments
4 participants