This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Reintroduce --timeout with deprecation warning #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
autodidaddict
approved these changes
Nov 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR, we made a breaking change to the
--timeoutflag instead making it--timeout-msand using milliseconds instead of seconds. We appropriately bumped a minor version, however this tended to affect a lot of scripting across our organization and likely affects others, so retroactively I'm adding--timeoutback with a deprecation warning. Going forward when changing the CLI API, we'll be sure to deprecate features first to maintain compatibility and THEN remove them after two breaking change bumps.After this merges, we'll release
v0.7.1with this change