This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
ref(link): Return better errors when provider id is given #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomastaylor312
requested review from
autodidaddict and
brooksmtownsend
as code owners
autodidaddict
previously approved these changes
Nov 23, 2021
It is relatively common for first time users to pass the provider id rather than the contract ID when doing `wash ctl link del`. This adds a block that tests if it is a provider ID and returns a hint to the user. I also noticed we weren't returning an error code on link commands if they failed, so I added some logic to fix it Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
thomastaylor312
force-pushed
the
ref/better_link_error
branch
from
23e86d0
to
1f2ad93
Compare
brooksmtownsend
approved these changes
Nov 24, 2021
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is relatively common for first time users to pass the provider id rather
than the contract ID when doing
wash ctl link del. This adds a blockthat tests if it is a provider ID and returns a hint to the user. I also
noticed we weren't returning an error code on link commands if they failed,
so I added some logic to fix it