Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Draft: Update Github Actions #205

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Conversation

ghost
Copy link

@ghost ghost commented Nov 21, 2021

Fixes #189.

Updated all occurrences of actions/checkout to use the v2 version.

Changed the release job to use softprops/action-gh-release@v1, as used in https://github.com/wasmCloud/wasmcloud-otp.
Wasmcloud-otp creates tarballs for each platform and puts them in the Github Release though, and I wasn't sure if that was something that should be done here. I'm leaning towards no because wash is already distributed through the various package managers, but interested to hear any feedback on that.

Signed-off-by: Matt Wilkinson <mattwilki17@gmail.com>
@ghost
Copy link
Author

ghost commented Nov 21, 2021

Ah didn't see #190 before opening this. That one doesn't appear to update the checkout actions though.

@autodidaddict
Copy link
Member

@brooksmtownsend @jordan-rash we should rationalize between this Pr and #190 .

@jordan-rash
Copy link
Member

Agree. I think, at this point, I will close #190 and we move forward with this one. The primary focus on #190 was to get brew automation working and not the critical updates that @mattwilkinsonn did here.

Also, in my getting more familiar with brew, it turns out, deep in the bowels of their documentation, there is a better way than what I proposed in #190. So I will leave the branch there, but we can get rid of the PR for now.

@jordan-rash
Copy link
Member

One thing that sticks out here is the linting. We should probably have a common action that does a linting check on the yaml for all our GHAs.

Screen Shot 2021-11-22 at 7 47 14 AM

@ghost
Copy link
Author

ghost commented Nov 22, 2021

One thing that sticks out here is the linting. We should probably have a common action that does a linting check on the yaml for all our GHAs.

Screen Shot 2021-11-22 at 7 47 14 AM

Yeah I noticed that as well. The YAML formatter I have on VSCode auto fixed it, but could be useful to have it lint in the CI itself.

Some google searching led me here https://github.com/marketplace/actions/yaml-schema-validator and https://github.com/marketplace/actions/yaml-lint

Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I agree with you that there's no need to compile+attach the wash binary since we already have other mechanisms for distribution. As long as the actions pass this LGTM

@brooksmtownsend brooksmtownsend merged commit 681b73f into wasmCloud:main Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrub GHA actions
3 participants