-
Notifications
You must be signed in to change notification settings - Fork 57
feat(*): fetch from wasmcloud cache on inspect commands #204
feat(*): fetch from wasmcloud cache on inspect commands #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff @matthewtgilbride, really only had one nit comment here.
fdc2b36
to
a6eb69d
Compare
Thanks @brooksmtownsend - renamed things to "local_artifact" and "cached_artifact - along moving the local/cache/remote helper to I'm wondering what the best way to test this is? I was thinking of jamming the |
I think that's a good idea, a good baseline would be a unit test just to verify:
One great way you could test this is exactly what you suggested, throw the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM @matthewtgilbride, just need the DCO fix 😄 If you check the workflow details it'll tell you the command you can run
a22af42
to
404d9db
Compare
- includes new --no-cache option for inspect commands Signed-off-by: matthewtgilbride <matthewtgilbride@gmail.com>
404d9db
to
d57f9d2
Compare
👍 think I'm ready. Added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought of one more request... could you also add a test for the provider so that we test that works as well? I figure having a wash claims inspect
+ wash par inspect
would be great
🦃 done Interestingly the |
That's a fun one actually that we worried about as we started, turns out the whole compress/decompress part of the gzip library we use is SUPER slow in debug mode, so hopefully if we try with release mode that doesn't reproduce |
Signed-off-by: matthewtgilbride <matthewtgilbride@gmail.com>
fe3f0bc
to
94d197f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, and should be ready to merge as soon as the tests run and pass 🚀
Closes #138