-
Notifications
You must be signed in to change notification settings - Fork 57
Cluster seed validation for CLI args (and interactive) #202
Conversation
57560e6
to
5032140
Compare
Signed-off-by: Stuart Harris <stuart.harris@red-badger.com>
Signed-off-by: Stuart Harris <stuart.harris@red-badger.com>
Signed-off-by: Stuart Harris <stuart.harris@red-badger.com>
Signed-off-by: Stuart Harris <stuart.harris@red-badger.com>
Signed-off-by: Stuart Harris <stuart.harris@red-badger.com>
5032140
to
7dbca8c
Compare
@brooksmtownsend opening this up for review, but would love to get your opinion on what |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I'd like @brooksmtownsend to double-check this to make sure it works fine in conjunction with the automatic configuration reading ~/.wash/host_config.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell this looks good with wash ctx
. Turns out seed keys are 58 characters so valid keys won't parse with this iteration. After doing some testing I found a few more requests.
Signed-off-by: Stuart Harris <stuart.harris@red-badger.com>
Signed-off-by: Stuart Harris <stuart.harris@red-badger.com>
Signed-off-by: Stuart Harris <stuart.harris@red-badger.com>
Signed-off-by: Stuart Harris <stuart.harris@red-badger.com>
b76a045
to
cef13db
Compare
This PR implements some more of #192 by introducing
ClusterSeed
for thewash call
command args and interactive input.Note there is a remaining question about what a default ClusterSeed should be (if anything), as this was previously an empty string (which won't parse now).
ClusterSeed
Id
andSeed
parsingClusterSeed::default()
(wrapsString::default()
)Also added a
.rustfmt.toml
to allowing merging imports, but happy to revert this if you think the imports are now "too merged" :-)