This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Public key CLI args validation #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stuart Harris <stuart.harris@red-badger.com>
StuartHarris
force-pushed
the
id-validation
branch
from
620d675
to
ff7a3a6
Compare
Signed-off-by: Stuart Harris <stuart.harris@red-badger.com>
StuartHarris
requested review from
autodidaddict,
billyoung and
brooksmtownsend
as code owners
Signed-off-by: Stuart Harris <stuart.harris@red-badger.com>
autodidaddict
approved these changes
Nov 18, 2021
| #[derive(Clone, Debug, Display, PartialEq, From, Into, Serialize, Deserialize)] | ||
| pub struct Id<const PREFIX: char>(String); | ||
|
|
||
| impl<const PREFIX: char> FromStr for Id<PREFIX> { |
There was a problem hiding this comment.
I've never seen this done like this before. This is very cool.
brooksmtownsend
approved these changes
Nov 18, 2021
StuartHarris
added a commit
to redbadger/wash
that referenced
this pull request
Nov 19, 2021
* Add Id const generic type, and HostId Signed-off-by: Stuart Harris <stuart.harris@red-badger.com> * ServerId, ServiceId, ModuleId Signed-off-by: Stuart Harris <stuart.harris@red-badger.com> * tiny refactor Signed-off-by: Stuart Harris <stuart.harris@red-badger.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially implements #192
Idthat can represent public keys with a constPREFIXServerId, with generic parameter'N'FromStrfor parsingStructOptto display error when input is invalidModuleIdandServiceId, with'M'and'V'respectively)